Skip to content

Commit

Permalink
Merge pull request #674 from tiennou/fix/libssh2-memory-keys
Browse files Browse the repository at this point in the history
Don't put the private key in the error message
  • Loading branch information
tiennou authored Oct 27, 2018
2 parents 6fe2c65 + 8cd2095 commit 9c6558b
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion ObjectiveGit/GTCredential.m
Original file line number Diff line number Diff line change
Expand Up @@ -77,7 +77,7 @@ + (instancetype)credentialWithUserName:(NSString *)userName publicKeyString:(NSS
git_cred *cred;
int gitError = git_cred_ssh_key_memory_new(&cred, userName.UTF8String, publicKeyString.UTF8String, privateKeyString.UTF8String, passphrase.UTF8String);
if (gitError != GIT_OK) {
if (error) *error = [NSError git_errorFor:gitError description:@"Failed to create credentials object" failureReason:@"There was an error creating a credential object for username %@ with the provided public/private key pair.\nPublic key: %@\nPrivate key: %@", userName, publicKeyString, privateKeyString];
if (error) *error = [NSError git_errorFor:gitError description:@"Failed to create credentials object" failureReason:@"There was an error creating a credential object for username %@ with the provided public/private key pair.\nPublic key: %@", userName, publicKeyString];
return nil;
}

Expand Down

0 comments on commit 9c6558b

Please sign in to comment.