Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add merge conflicted files to user info #550

Merged
merged 3 commits into from
Feb 3, 2016

Conversation

pietbrauer
Copy link
Member

This the add on to #538 (comment)

@joshaber joshaber self-assigned this Feb 3, 2016
@@ -20,6 +20,8 @@
#import "GTIndexEntry.h"
#import "git2/errors.h"

NSString * const GTPullMergeConflictedFiles = @"GTPullMergeConflictedFiles";
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should expose this from the header too, so users don't have to know the string literal.

@joshaber
Copy link
Member

joshaber commented Feb 3, 2016

Good idea 👍

@pietbrauer
Copy link
Member Author

Done 👍

@@ -11,6 +11,8 @@

NS_ASSUME_NONNULL_BEGIN

extern NSString * const GTPullMergeConflictedFiles;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Documentation please 😬

@joshaber
Copy link
Member

joshaber commented Feb 3, 2016

Just 1️⃣ 📝

@pietbrauer
Copy link
Member Author

Done ✅

@joshaber
Copy link
Member

joshaber commented Feb 3, 2016

🚢

joshaber added a commit that referenced this pull request Feb 3, 2016
…ror-info

Add merge conflicted files to user info
@joshaber joshaber merged commit d2e3eb7 into master Feb 3, 2016
@joshaber joshaber deleted the add-merge-conflicted-files-to-error-info branch February 3, 2016 02:14
@pietbrauer
Copy link
Member Author

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants