Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add list of files to merge conflict error #538

Merged
merged 1 commit into from
Jan 27, 2016

Conversation

pietbrauer
Copy link
Member

Currently we only return Merge conflict, pull aborted when a merge conflict is detected while pulling this enumerates the conflicted files and returns Merge conflict in files: index.html, _includes/head.html. Pull aborted..

Enumeration should be ok as it is most likely run in a background thread anyway. What do you think?

@tiennou
Copy link
Contributor

tiennou commented Jan 22, 2016

Maybe store that in the error's user info ?

@pietbrauer
Copy link
Member Author

Yeah true, will fix that.

@joshaber
Copy link
Member

I'm inclined to say that we should leave doing this in the users' hand. They may very well want a different error message, want it localized, etc.

@tiennou
Copy link
Contributor

tiennou commented Jan 22, 2016

Depends. It seems the index where conflicts originated is not accessible externally, so you'll have to perform the pull by hand afterward to get the conflicted list.

@pietbrauer
Copy link
Member Author

Yep, exactly My intention. To get the list of files we have to rebuild the pull feature.

@joshaber
Copy link
Member

Eh, yeah, fair enough.

joshaber added a commit that referenced this pull request Jan 27, 2016
@joshaber joshaber merged commit c574002 into master Jan 27, 2016
@joshaber joshaber deleted the better_merge_conflict_error_message branch January 27, 2016 05:05
@pietbrauer
Copy link
Member Author

@joshaber I will do another PR that sets the conflicted files in the user info?

@joshaber
Copy link
Member

Yep that's be great!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants