Skip to content

Don't reset extra_float_digits #1212

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
arp242 merged 1 commit into from
Jan 1, 2026
+8 −12
Merged

Don't reset extra_float_digits #1212

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 8 additions & 9 deletions conn_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -197,15 +197,14 @@ localhost:*:*:*:pass_C

assertPassword := func(extra values, expected string) {
o := values{
"host": "localhost",
"sslmode": "disable",
"connect_timeout": "20",
"user": "majid",
"port": "5432",
"extra_float_digits": "2",
"dbname": "pqgotest",
"client_encoding": "UTF8",
"datestyle": "ISO, MDY",
"host": "localhost",
"sslmode": "disable",
"connect_timeout": "20",
"user": "majid",
"port": "5432",
"dbname": "pqgotest",
"client_encoding": "UTF8",
"datestyle": "ISO, MDY",
}
for k, v := range extra {
o[k] = v
Expand Down
3 changes: 0 additions & 3 deletions connector.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,9 +55,6 @@ func NewConnector(dsn string) (*Connector, error) {
// * Explicitly passed connection information
o["host"] = "localhost"
o["port"] = "5432"
// N.B.: Extra float digits should be set to 3, but that breaks
// Postgres 8.4 and older, where the max is 2.
o["extra_float_digits"] = "2"
for k, v := range parseEnviron(os.Environ()) {
o[k] = v
}
Expand Down
Loading