Don't reset extra_float_digits#1212
Merged
Merged
Conversation
In PostgreSQL ≤11 the extra_float_digits parameter controlled how many digits were used for floating point numbers. It was set here to ensure people didn't accidentally needlessly lose precision (in 78a464e it was set to 3. In 5941153 it was changed to 2 as people reported problems on PostgreSQL ≤8.4, see #199). Since PostgreSQL 12 it will always use maximum precision unless it's set to ≤0. We only support PostgreSQL ≥14 now, so we can just remove it here. Ref: https://www.postgresql.org/docs/current/datatype-numeric.html#DATATYPE-FLOAT Fixes #475 Fixes #1150 Fixes #1146
songy23
added a commit
to open-telemetry/opentelemetry-collector-contrib
that referenced
this pull request
May 6, 2026
…v1.12.3 lib/pq v1.12.x removed the on-connect override that set extra_float_digits=2 (lib/pq#1212). Without that override, PostgreSQL 12+ uses the default extra_float_digits=1 and emits the shortest round-trip text representation for floats. The driver hands these strings to setDataPointValue, which parses them with strconv.ParseFloat, so the resulting float64 values change: - avg(action ratings): 7.6499999999999995 -> 7.65 - avg(scifi ratings): 8.200000000000001 -> 8.2 - 4.3::real: 4.3000002 -> 4.3 Update the expected metrics for TestPostgresqlDataSourceFieldsIntegrationMetrics accordingly. The sybase/sqlserver fixtures use a different driver and are not affected. Assisted-by: Claude Opus 4.7
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In PostgreSQL ≤11 the extra_float_digits parameter controlled how many digits were used for floating point numbers. It was set here to ensure people didn't accidentally needlessly lose precision (in 78a464e it was set to 3. In 5941153 it was changed to 2 as people reported problems on PostgreSQL ≤8.4, see #199).
Since PostgreSQL 12 it will always use maximum precision unless it's set to ≤0. We only support PostgreSQL ≥14 now, so we can just remove it here.
Ref: https://www.postgresql.org/docs/current/datatype-numeric.html#DATATYPE-FLOAT
Fixes #475
Fixes #1150
Fixes #1146