Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI: Support PR Preview #38

Merged
merged 12 commits into from
Sep 9, 2022
+65 −23
Merged

CI: Support PR Preview #38

Changes from 1 commit
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
95dee33
CI: Add pull request preview workflow
Shaikh-Ubaid Aug 21, 2022
a2faec7
CI: Add steps from pr_preview.yml to deploy.yml
Shaikh-Ubaid Aug 22, 2022
cdd3d6c
CI: Remove pr_preview.yml workflow
Shaikh-Ubaid Aug 22, 2022
d332be8
CI: Run deploy workflow on pull requests
Shaikh-Ubaid Aug 22, 2022
96b256c
CI: Push to respective repos depending on branch
Shaikh-Ubaid Aug 22, 2022
e821a33
CI: Comment only on pull request and when running at origin
Shaikh-Ubaid Aug 22, 2022
f7622ba
CI: Update the repository links
Shaikh-Ubaid Aug 22, 2022
893812e
CI: Update preview link
Shaikh-Ubaid Aug 22, 2022
0e80d77
Fix path
Shaikh-Ubaid Aug 21, 2022
e881b20
Revert "Fix path"
Shaikh-Ubaid Aug 22, 2022
292a1f9
CI: Fix: pushing to production
Shaikh-Ubaid Aug 22, 2022
3e51eb2
Do not use ssh keys when in main branch
Shaikh-Ubaid Aug 22, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
CI: Fix: pushing to production
@Shaikh-Ubaid
Shaikh-Ubaid committed Aug 22, 2022
commit 292a1f98349000292856790efba131cdb41fc6f5
8 changes: 5 additions & 3 deletions ci/upload_site.sh
View file
Original file line number Diff line number Diff line change
@@ -39,9 +39,11 @@ git add .
COMMIT_MESSAGE="Deploying on $(date "+%Y-%m-%d %H:%M:%S")"
git commit -m "${COMMIT_MESSAGE}"

if [[ "${GIT_PR_PREVIEW_PRIVATE_SSH_KEY}" == "" ]]; then
echo "Note: GIT_PR_PREVIEW_PRIVATE_SSH_KEY is empty, skipping..."
exit 0
if [[ ${git_ref} != "refs/heads/main" ]]; then
if [[ "${GIT_PR_PREVIEW_PRIVATE_SSH_KEY}" == "" ]]; then
echo "Note: GIT_PR_PREVIEW_PRIVATE_SSH_KEY is empty, skipping..."
exit 0
fi
fi
ssh-add <(echo "$GIT_PR_PREVIEW_PRIVATE_SSH_KEY" | base64 -d)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We already have ssh keys setup with a different variable (I believe), so this PR will only use GIT_PR_PREVIEW_PRIVATE_SSH_KEY to push even to production?

I think we should use the production keys for production and preview keys for previews, what do you think?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We already have ssh keys setup with a different variable (I believe), so this PR will only use GIT_PR_PREVIEW_PRIVATE_SSH_KEY to push even to production?

It seems there are no ssh keys required to push to production (as we discussed here #1 (comment) and also tried/tested it by removing the SSH key setup step here c6cee87). We currently need the SSH keys for pushing the test version to pull_request_preview (as pull_request_preview is a separate repository). During production deployment, even if the SSH keys would be available, I guess/think that they would (hopefully) not be used.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We already have ssh keys setup with a different variable (I believe)

Please, could you possibly share if it would be possible to rename it and setup its public key at https://github.com/lfortran/pull_request_preview, please

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see. It's a little weird that it would quit to push to production if GIT_PR_PREVIEW_PRIVATE_SSH_KEY is empty. But I guess that's fine. Would it make sense to put this into if [[ ${git_ref} != "refs/heads/main" ]]; then if statement?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, got it.