Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI: Add CI for auto deploying site #1

Merged
merged 2 commits into from
Aug 12, 2022

Conversation

Shaikh-Ubaid
Copy link
Member

This PR adds support for building and deploying the site from the main branch to the gh-pages branch.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
@Shaikh-Ubaid Shaikh-Ubaid marked this pull request as draft August 10, 2022 15:29
@Shaikh-Ubaid
Copy link
Member Author

This is the same/similar CI that I use to build https://www.ubaidshaikh.me/.

Currently, I am marking this PR as draft. We can add the CI part later as we discussed during the meet.

@certik
Copy link
Contributor

certik commented Aug 10, 2022

Looks good, let me know if you need any help from me to set it up.

@Shaikh-Ubaid
Copy link
Member Author

let me know if you need any help from me to set it up.

Sure, I will let you know. Thank you.

@Shaikh-Ubaid Shaikh-Ubaid marked this pull request as ready for review August 12, 2022 17:09
@Shaikh-Ubaid
Copy link
Member Author

Shaikh-Ubaid commented Aug 12, 2022

This is ready. Please possibly review and please share feedback.

Copy link
Contributor

@certik certik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is good. Go ahead and merge it. Let's set it up.

@Shaikh-Ubaid Shaikh-Ubaid merged commit 27a7646 into lfortran:master Aug 12, 2022
@Shaikh-Ubaid Shaikh-Ubaid deleted the ci_deploy branch August 12, 2022 20:50
echo "Note: GIT_DEPLOY_PRIVATE_SSH_KEY is empty, skipping..."
exit 0
fi
ssh-add <(echo "$GIT_DEPLOY_PRIVATE_SSH_KEY" | base64 -d)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like this is not necessary, since it is able to push into gh-pages anyway, since it is in the same repository?

325101d

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am unsure. I too observed it and was to open an issue about it soon.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I assumed that the GIT_DEPLOY_PRIVATE_SSH_KEY SSH Keys were setup and probably the if was falsely evaluating to true.

Please, could you possibly clarify if currently the CI is pushing without the SSH keys?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I checked and there is nothing set in the Settings, no variables.

I think the reason it works is because we are pushing into the same repository and the GitHub CI itself is able to pull from it, so you can also push into it, or something like that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants