-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CI: Add CI for auto deploying site #1
Conversation
This is the same/similar Currently, I am marking this |
Looks good, let me know if you need any help from me to set it up. |
Sure, I will let you know. Thank you. |
This is ready. Please possibly review and please share feedback. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this is good. Go ahead and merge it. Let's set it up.
echo "Note: GIT_DEPLOY_PRIVATE_SSH_KEY is empty, skipping..." | ||
exit 0 | ||
fi | ||
ssh-add <(echo "$GIT_DEPLOY_PRIVATE_SSH_KEY" | base64 -d) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like this is not necessary, since it is able to push into gh-pages
anyway, since it is in the same repository?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am unsure. I too observed it and was to open an issue about it soon.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I assumed that the GIT_DEPLOY_PRIVATE_SSH_KEY
SSH Keys were setup and probably the if
was falsely evaluating to true
.
Please, could you possibly clarify if currently the CI
is pushing without the SSH
keys?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I checked and there is nothing set in the Settings, no variables.
I think the reason it works is because we are pushing into the same repository and the GitHub CI itself is able to pull from it, so you can also push into it, or something like that.
This
PR
adds support for building and deploying the site from themain
branch to thegh-pages
branch.