Skip to content

Conversation

@pgporada
Copy link
Member

@pgporada pgporada commented May 24, 2024

#444 removed exposing the API and management ports directly in the Dockerfile in favor of the docker-compose.yml. Not everyone will be using docker compose so let's document how it should be done.

Fixes #452

@mcpherrinm
Copy link
Contributor

It’s not quite so simple, because we use the same docker file for both pebble and pebble-challtestsrv

@pgporada
Copy link
Member Author

We should split that apart then so they behave appropriately running as one-off docker run's or docker compose up.

@mcpherrinm
Copy link
Contributor

EXPOSE is only really for the use docker run --publish-all instead of specifying the ports with -p, which is at most a minor inconvenience IMO, so we should consider how much extra complexity we want to add here to support that

@pgporada
Copy link
Member Author

How about switching all the documented docker run steps to add in those ports?

@pgporada pgporada changed the title Expose API and management ports in dockerfile Document exposing API and management ports when not using docker-compose.yaml May 24, 2024
@pgporada pgporada merged commit ad9e5bb into main May 31, 2024
@pgporada pgporada deleted the fix-port-mapping branch May 31, 2024 18:00
kwatson added a commit to kwatson/letsencrypt-pebble that referenced this pull request Jun 9, 2025
* 'main' of https://github.com/letsencrypt/pebble: (35 commits)
  add overriding of ARI response (letsencrypt#501)
  wfe: fix a race in `orderForDisplay` (letsencrypt#500)
  Bump golang.org/x/ dependencies (letsencrypt#499)
  currectly triggers BadSignatureAlgorithmProblem at JWS parse time (letsencrypt#492)
  use newer validation subdomain for dns-account-01 (fix CI eggsampler/acme error) (letsencrypt#498)
  Orders don't have a "deactivated" status. (letsencrypt#301)
  Update golangci-lint (letsencrypt#488)
  build(deps): bump github.com/go-jose/go-jose/v4 from 4.0.4 to 4.0.5 (letsencrypt#487)
  Truncate ARI timestamps to millisecond resolution (letsencrypt#485)
  return logical and compliant ARI windows for expiring certs (letsencrypt#484)
  Update dependencies (letsencrypt#481)
  docs: rm mention of subproblems being unimpl'd (letsencrypt#479)
  Fix(NOISSUE): Fix docker compose file example in README.md (letsencrypt#475)
  Add support for ACME Profiles (letsencrypt#473)
  Simplify KU, EKU, and SKID fields of issued certs (letsencrypt#472)
  Update golangci-lint to 1.60.2 (letsencrypt#474)
  Update /x/net for compatibility with go1.23 (letsencrypt#470)
  Reject extra command line args and fix README invocation (letsencrypt#467)
  Document exposing API and management ports when not using docker-compose.yaml (letsencrypt#465)
  Implement latest draft-ietf-acme-ari spec (letsencrypt#461)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Cannot set DNS server in Docker image

4 participants