Skip to content

fix: lower missing-interaction-state to -1 suggestion (#210) #228

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
let-sunny merged 2 commits into from
Mar 31, 2026
+4 −4
Merged

fix: lower missing-interaction-state to -1 suggestion (#210) #228

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
eb8963a
fix: lower missing-interaction-state to -1 suggestion instead of disa…
let-sunny Mar 31, 2026
41351c6
docs: update rule-config comment to reflect interaction score change
let-sunny Mar 31, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion docs/CUSTOMIZATION.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -134,7 +134,7 @@ Override score, severity, or enable/disable individual rules:

| Rule ID | Default Score | Default Severity |
|---------|--------------|-----------------|
| `missing-interaction-state` | -5 | risk |
| `missing-interaction-state` | -1 | suggestion |
| `missing-prototype` *(disabled)* | -3 | missing-info |
<!-- RULE_TABLE_END -->

Expand Down
6 changes: 3 additions & 3 deletions src/core/rules/rule-config.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,7 @@ export const RULE_ID_CATEGORY: Record<RuleId, Category> = {
* - responsive-critical: -8 ~ -6 (size-constraints ΔV +15.9% at responsive viewports)
* - code-quality: -7 ~ -3 (CSS classes -8~15, no pixel impact)
* - token-management: -5 ~ -4 (wrong input = wrong output, irregular spacing actively causes errors)
* - interaction: -5 (wrong guess > omission, interview confirmed)
* - interaction: -1 (uncalibrated — no metric to validate, kept minimal #210)
* - semantic: -4 ~ -1 (non-semantic-name upgraded per interview — causes actual implementation errors)
*
* Category weights removed (#196) — overall score is simple average of categories.
Expand Down Expand Up @@ -127,8 +127,8 @@ export const RULE_CONFIGS: Record<RuleId, RuleConfig> = {

// ── Interaction ──
"missing-interaction-state": {
severity: "risk",
score: -5,
severity: "suggestion",
score: -1, // uncalibrated: no metric to validate score (#210), kept at -1 to preserve category visibility
enabled: true,
},
"missing-prototype": {
Expand Down
Loading