Skip to content

fix: lower missing-interaction-state to -1 suggestion (#210)#228

Merged
let-sunny merged 2 commits intomainfrom
fix/interaction-minimal-score
Mar 31, 2026
Merged

fix: lower missing-interaction-state to -1 suggestion (#210)#228
let-sunny merged 2 commits intomainfrom
fix/interaction-minimal-score

Conversation

@let-sunny
Copy link
Copy Markdown
Owner

@let-sunny let-sunny commented Mar 31, 2026

Summary

  • Lower missing-interaction-state from -5 risk to -1 suggestion instead of disabling it
  • Keeps the interaction category visible in the 6-gauge grid
  • Score is minimal since the rule is uncalibrated — no validated metric yet
  • Once a proper calibration metric is found, the score can be raised via the normal calibration pipeline

Related: #210 (interim mitigation — full calibration infrastructure is separate work)

Test plan

  • pnpm test:run — 656 tests pass
  • Report renders 6 category gauges (interaction included)

🤖 Generated with Claude Code

…bling (#210)

Keep the interaction category visible in the 6-gauge grid by reducing
the uncalibrated rule to minimal score rather than disabling it entirely.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai bot commented Mar 31, 2026

📝 Walkthrough

Walkthrough

The missing-interaction-state rule's default configuration was adjusted in both documentation and code: its score decreased from -5 to -1 and severity changed from risk to suggestion. The comment was updated to reflect an "uncalibrated" status.

Changes

Cohort / File(s) Summary
Documentation Update
docs/CUSTOMIZATION.md
Updated rule documentation to reflect revised default score (-5-1) and severity (risksuggestion) for the missing-interaction-state rule.
Rule Configuration
src/core/rules/rule-config.ts
Modified RULE_CONFIGS["missing-interaction-state"] exported constant: severity downgraded to suggestion, score reduced to -1, and interaction comment replaced with "uncalibrated" note reflecting the lack of a validation metric.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~8 minutes

Possibly related PRs

Poem

🐰 A rule once bold with risk and might,
Now whispers soft as morning light—
Score trimmed back, severity bent,
We calibrate with discernment! ✨

🚥 Pre-merge checks | ✅ 3 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Linked Issues check ⚠️ Warning The PR only implements a temporary score reduction for an uncalibrated rule, but issue #210 requires comprehensive infrastructure changes including strip type addition, calibration pipeline updates, token/CSS metrics integration, and CLI extensions—none of which are present in this PR. This PR should be part of a larger effort addressing #210's acceptance criteria. Either implement the full calibration infrastructure or clarify if this is a interim mitigation pending the full solution.
✅ Passed checks (3 passed)
Check name Status Explanation
Title check ✅ Passed The title accurately describes the main change: lowering the missing-interaction-state rule score to -1 and changing severity to suggestion, which matches the code changes in both documentation and rule configuration files.
Out of Scope Changes check ✅ Passed All changes are directly scoped to updating the missing-interaction-state rule configuration and documentation; no unrelated modifications are present.
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/interaction-minimal-score

Comment @coderabbitai help to get the list of available commands and usage tips.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
@let-sunny let-sunny marked this pull request as ready for review March 31, 2026 12:40
@let-sunny let-sunny merged commit 7ffa433 into main Mar 31, 2026
3 checks passed
@let-sunny let-sunny deleted the fix/interaction-minimal-score branch March 31, 2026 12:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant