Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add JSON Path support for RestGenerator #651

Merged
merged 6 commits into from
May 11, 2024
Merged

Add JSON Path support for RestGenerator #651

merged 6 commits into from
May 11, 2024

Conversation

leondz
Copy link
Owner

@leondz leondz commented May 2, 2024 •
edited
Loading

currently, when services return json, folk can only specify a top-level dict key from where to get the response

proposal: move to a JSONPath in the response_json_field variable

@leondz leondz linked an issue May 2, 2024 that may be closed by this pull request
restgen json access enhancements #487
Closed
@leondz leondz marked this pull request as ready for review May 3, 2024 12:14
@leondz leondz requested a review from jmartin-tech May 3, 2024 12:14
@leondz leondz mentioned this pull request May 3, 2024
Closed
@leondz leondz marked this pull request as draft May 10, 2024 13:11
@leondz leondz marked this pull request as ready for review May 10, 2024 13:14
jmartin-tech
jmartin-tech approved these changes May 10, 2024
View reviewed changes
Copy link
Collaborator

@jmartin-tech jmartin-tech left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor optional request for better input validation.

garak/generators/rest.py Show resolved Hide resolved
@leondz leondz merged commit 9a59e21 into main May 11, 2024
6 checks passed
@leondz leondz deleted the features/restgen_jsonpath branch May 11, 2024 11:52
@github-actions github-actions bot locked and limited conversation to collaborators May 11, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jmartin-tech jmartin-tech jmartin-tech approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

restgen json access enhancements
2 participants
@leondz @jmartin-tech