Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Nested Json API Responses #635

Closed
wants to merge 1 commit into from
Closed

Conversation

au70ma70n
Copy link

No description provided.

Copy link
Contributor

DCO Assistant Lite bot:
Thank you for your submission, we really appreciate it. Like many open-source projects, we ask that you sign our Developer Certificate of Origin before we can accept your contribution. You can sign the DCO by just posting a Pull Request Comment same as the below format.


I have read the DCO Document and I hereby sign the DCO


You can retrigger this bot by commenting recheck in this Pull Request

@au70ma70n
Copy link
Author

I have read the DCO Document and I hereby sign the DCO

@jmartin-tech
Copy link
Collaborator

@au70ma70n can you update the description here to explain what the goal is here and why it would be a default functionality?

Can you provided some examples of configuration and responses both impacted and not impacted by this revision?

If I am understanding this correctly the need here is to extract a value in the result as the response_json_field that is not at the top level of the parsed response.

Thinking on this would there be value in enabling response_json_field to be a JSONPath query?

@leondz
Copy link
Collaborator

leondz commented Apr 26, 2024

Is this related to issue #487 ?

Thinking on this would there be value in enabling response_json_field to be a JSONPath query?

see #487 :)

@leondz leondz added the generators Interfaces with LLMs label Apr 30, 2024
@leondz
Copy link
Collaborator

leondz commented Apr 30, 2024

@au70ma70n Thanks very much for this. We'll cue up a general fix for the next few days.

@leondz leondz added the bug Something isn't working label Apr 30, 2024
@leondz
Copy link
Collaborator

leondz commented May 3, 2024

tracking general fix in #651

@leondz
Copy link
Collaborator

leondz commented May 11, 2024

flexible fix provided in #651 (now merged). thank you for pushing this along!

@leondz leondz closed this May 11, 2024
@github-actions github-actions bot locked and limited conversation to collaborators May 11, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working generators Interfaces with LLMs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants