fix: WMI disposal in SystemInfoService, brush freeze, collection expressions (CQ-002, MODERN-003)#378
Merged
Merged
Conversation
…essions (CQ-002, MODERN-003)
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (7)
📜 Recent review details⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (2)
🔇 Additional comments (8)
📝 WalkthroughWalkthroughThis PR consolidates maintenance improvements for v0.48.14: proper disposal of WMI ManagementObject instances in SystemInfoService query methods, narrowed exception handling in HexToBrushConverter, and collection-expression modernization replacing Array.Empty() across file-scanning services. ChangesResource disposal and code modernization
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Possibly related PRs
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Comment |
|
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| var uptime = TimeSpan.Zero; | ||
| if (!string.IsNullOrEmpty(lastBootRaw)) | ||
| { | ||
| try { uptime = DateTime.Now - ManagementDateTimeConverter.ToDateTime(lastBootRaw); } catch (FormatException) { } catch (InvalidCastException) { } |
| var uptime = TimeSpan.Zero; | ||
| if (!string.IsNullOrEmpty(lastBootRaw)) | ||
| { | ||
| try { uptime = DateTime.Now - ManagementDateTimeConverter.ToDateTime(lastBootRaw); } catch (FormatException) { } catch (InvalidCastException) { } |
This was referenced May 15, 2026
laurentiu021
added a commit
that referenced
this pull request
May 22, 2026
#481) ## Summary Fully implements the App Blocker tab, replacing the WIP placeholder. Blocks applications from executing using the Image File Execution Options (IFEO) registry mechanism. ## Changes - **New**: \AppBlockerService\ — uses IFEO Debugger key to prevent app execution. Block, unblock, check status, enumerate all blocked apps. Fully reversible. - **New**: \AppBlockerViewModel\ — block by name or browse, unblock selected, refresh list, select/deselect all. Admin privilege detection. - **New**: \BlockedApp\ model — executable name, full path, blocked timestamp, selection state. - **New**: \AppBlockerView.xaml\ — text input + browse, toolbar, DataGrid. - **Updated**: \MainWindowViewModel\ — replaced \WipAppBlocker\ placeholder with real \AppBlockerViewModel\. - **Tests**: 5 unit tests for ViewModel and Model. ## Safety - Confirmation dialog before block and unblock - Admin privilege check with clear status message - Fully reversible — unblock removes the IFEO Debugger key - Only blocks apps marked by SysManager (checks for specific debugger path) Closes #378 Co-authored-by: laurentiu021 <laurentiu021@users.noreply.github.com>
laurentiu021
added a commit
that referenced
this pull request
May 22, 2026
…essions (CQ-002, MODERN-003) (#378) Co-authored-by: laurentiu021 <laurentiu021@users.noreply.github.com>
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Priority 2 fixes from QA audit.
Changes
CQ-002: SystemInfoService WMI disposal
Brush freeze
MODERN-003: Array.Empty → []
Housekeeping
Build
Summary by CodeRabbit
Bug Fixes
Chores