Skip to content

chore: add ci config #78

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
yusinto merged 2 commits into from
Apr 13, 2023
Merged

chore: add ci config #78

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4eb1b3e
chore: added ci config
yusinto Apr 12, 2023
d9b0c70
fix: typedoc error index.ts not included in tsconfig.
yusinto Apr 12, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 24 additions & 0 deletions .github/workflows/cloudflare.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,24 @@
name: sdk/cloudflare

on:
push:
branches: [main]
paths-ignore:
- '**.md' #Do not need to run CI for markdown changes.
pull_request:
branches: [main]
paths-ignore:
- '**.md'

jobs:
build-test-cloudflare:
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v3
- uses: actions/setup-node@v3
- id: shared
name: Shared CI Steps
uses: ./actions/ci
with:
workspace_name: '@launchdarkly/cloudflare-server-sdk'
workspace_path: packages/sdk/cloudflare
5 changes: 3 additions & 2 deletions packages/sdk/cloudflare/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,9 +16,9 @@
"/dist"
],
"scripts": {
"build": "yarn tsc",
"build": "rimraf dist && yarn tsc",
Copy link
Member

@kinyoklion kinyoklion Apr 13, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

rimraf is probably fine, but yarn clean does delete the output files. It doesn't delete the folders though, which may be inconvenient.

"tsw": "yarn tsc --watch",
"start": "yarn tsw",
"start": "rimraf dist && yarn tsw",
"lint": "eslint . --ext .ts",
"prettier": "prettier --write '**/*.@(js|ts|tsx|json|css)'",
"test": "jest --ci --runInBand",
Expand All @@ -43,6 +43,7 @@
"jest": "^29.5.0",
"launchdarkly-js-test-helpers": "^2.2.0",
"prettier": "^2.8.7",
"rimraf": "^5.0.0",
"ts-jest": "^29.1.0",
"typedoc": "0.23.26",
"typescript": "^5.0.3"
Expand Down
20 changes: 10 additions & 10 deletions packages/sdk/cloudflare/tsconfig.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,19 +3,19 @@
// Uses "." so it can load package.json.
"rootDir": ".",
"outDir": "dist",
"target": "es2021",
"lib": ["es2021"],
"jsx": "react",
"target": "es6",
"lib": ["es6"],
"module": "es2022",
"strict": true,
"noImplicitOverride": true,
"allowSyntheticDefaultImports": true,
"sourceMap": true,
"declaration": true,
"declarationMap": true, // enables importers to jump to source
"resolveJsonModule": true,
"stripInternal": true,
Copy link
Member

@kinyoklion kinyoklion Apr 13, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just as a warning I have had some problems with doc generation for "stripInternal". I like the option generally though. But if you encounter some doc problem toggling this can help narrow down what it is angry about.

"moduleResolution": "node",
"types": ["@cloudflare/workers-types", "jest", "node"],
"resolveJsonModule": true,
"allowJs": true,
"checkJs": false,
"isolatedModules": true,
"allowSyntheticDefaultImports": true,
"forceConsistentCasingInFileNames": true,
"strict": true,
"skipLibCheck": true
},
"exclude": ["**/*.test.ts", "dist", "node_modules", "__tests__", "example"]
Expand Down