chore: add ci config #78
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request has been linked to Shortcut Story #197085: Add ci config. |
yusinto
changed the base branch from
main
to
yus/sc-195479/move-cloudflare-sdk-to-js-core
kinyoklion
reviewed
Apr 13, 2023
| ], | ||
| "scripts": { | ||
| "build": "yarn tsc", | ||
| "build": "rimraf dist && yarn tsc", |
Member
There was a problem hiding this comment.
rimraf is probably fine, but yarn clean does delete the output files. It doesn't delete the folders though, which may be inconvenient.
kinyoklion
reviewed
Apr 13, 2023
| "declaration": true, | ||
| "declarationMap": true, // enables importers to jump to source | ||
| "resolveJsonModule": true, | ||
| "stripInternal": true, |
Member
There was a problem hiding this comment.
Just as a warning I have had some problems with doc generation for "stripInternal". I like the option generally though. But if you encounter some doc problem toggling this can help narrow down what it is angry about.
kinyoklion
approved these changes
Apr 13, 2023
yusinto
added a commit
that referenced
this pull request
Apr 13, 2023
* chore: setup src folder and example app dependencies * chore: remove redundant tsconfig watch options * chore: replaced workspace deps with version numbers. Convert featureStore and configuration to ts. * chore: implemented platform and ldclient * chore: added randomUUID implementation * chore: added Requests with MockEventSource * chore: implemented crypto using crypto-js. Renamed platform files. Fixed example app. * fix: import events to node:events * test: first round debugging. preview data not visible for some reason. * chore: improved logging and test data. * chore: improve folder and file structures * chore: miniflare and unit tests now works * chore: added unit tests * chore: test store using async facade * chore: added more unit tests. added util functions. dryd unit tests. * fix: eslint single export issue. * chore: remove internal to generate types for AsyncStoreFacade. * fix: ignore dist folder from jest config * chore: remove example folder for now * chore: remove example app from workspace for now * chore: improve comments * Update README.md * Create CHANGELOG.md * Update README.md * chore: added typedoc comments * Update tsconfig.json * chore: use package.json name and version * chore: add ci config (#78) * chore: added ci config * fix: typedoc error index.ts not included in tsconfig. * chore: add miniflare tests (#76) * chore: added miniflare dep and initial test file. * fix: suppress node warnings and enable modules when running jest * chore: added miniflare tests * chore: turned on jest coverage flag * chore: add prettierignore --------- Co-authored-by: Yusinto Ngadiman <[email protected]> * chore: moved MockEventSource for sharing (#75) * chore: moved eventSource for sharing * chore: renamed MockEventSource NullEventSource * chore: prettier ignore coverage folder --------- Co-authored-by: Yusinto Ngadiman <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding ci config for cloudflare.