feat: Implement browser crypto and encoding. #574
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kinyoklion
commented
Sep 6, 2024
| @@ -27,15 +27,15 @@ | |||
| ], | |||
| "scripts": { | |||
| "clean": "rimraf dist", | |||
| "build": "vite build", | |||
| "build": "tsc --noEmit && vite build", | |||
There was a problem hiding this comment.
Need to have tsc --noEmit to validate the typescript vite just builds it and doesn't type check.
kinyoklion
commented
Sep 6, 2024
| "lint": "eslint . --ext .ts,.tsx", | ||
| "prettier": "prettier --write '**/*.@(js|ts|tsx|json|css)' --ignore-path ../../../.prettierignore", | ||
| "test": "jest", | ||
| "coverage": "yarn test --coverage", | ||
| "check": "yarn prettier && yarn lint && yarn build && yarn test" | ||
| }, | ||
| "dependencies": { | ||
| "@launchdarkly/js-client-sdk-common": "1.5.0" | ||
| "@launchdarkly/js-client-sdk-common": "1.7.0" |
There was a problem hiding this comment.
Until we automate releases we need to manually update this or it will used the published version instead of the repo version. We could enable release-please and just not publish.
kinyoklion
commented
Sep 6, 2024
| @@ -0,0 +1,99 @@ | |||
| // The implementation in this file generates UUIDs in v4 format and is suitable | |||
There was a problem hiding this comment.
This code was implemented for error monitoring, but that is still on a feature branch.
I think, after the client is working, we need to make a browser-common containing things that can be used in browser SDKs.
…b/sc-254416/implement-browser-crypto-encoding
…ithub.com:launchdarkly/js-server-sdk-private into rlamb/sc-254416/implement-browser-crypto-encoding
kinyoklion
commented
Sep 9, 2024
| @@ -4,7 +4,7 @@ | |||
| "declaration": true, | |||
| "declarationMap": true, | |||
| "jsx": "react-jsx", | |||
| "lib": ["es6", "dom"], | |||
| "lib": ["ES2017", "dom"], | |||
There was a problem hiding this comment.
I think that es2017 should be an acceptable target, but we can lower it if we need to.
If we do lower it, then we would need to remove the TextEncoder usage.
Base automatically changed from
rlamb/add-platform-support-for-async-hashing
to
main
September 9, 2024 20:06
tanderson-ld
approved these changes
Sep 9, 2024
kinyoklion
deleted the
rlamb/sc-254416/implement-browser-crypto-encoding
branch
Merged
kinyoklion
pushed a commit
that referenced
this pull request
Oct 10, 2024
🤖 I have created a release *beep* *boop* --- <details><summary>js-client-sdk: 0.0.1</summary> ## 0.0.1 (2024-10-10) ### Features * Add basic secure mode support for browser SDK. ([#598](#598)) ([3389983](3389983)) * Add bootstrap support. ([#600](#600)) ([4e5dbee](4e5dbee)) * Add browser info. ([#576](#576)) ([a2f4398](a2f4398)) * Add ESM support for common and common-client (rollup) ([#604](#604)) ([8cd0cdc](8cd0cdc)) * Add support for browser contract tests. ([#582](#582)) ([38f081e](38f081e)) * Add support for hooks. ([#605](#605)) ([04d347b](04d347b)) * Add support for js-client-sdk style initialization. ([53f5bb8](53f5bb8)) * Add support for localStorage for the browser platform. ([#566](#566)) ([4792391](4792391)) * Add URLs for custom events and URL filtering. ([#587](#587)) ([7131e69](7131e69)) * Add visibility handling to allow proactive event flushing. ([#607](#607)) ([819a311](819a311)) * adds datasource status to sdk-client ([#590](#590)) ([6f26204](6f26204)) * Adds support for REPORT. ([#575](#575)) ([916b724](916b724)) * Browser-SDK Automatically start streaming based on event handlers. ([#592](#592)) ([f2e5cbf](f2e5cbf)) * Implement browser crypto and encoding. ([#574](#574)) ([e763e5d](e763e5d)) * Implement goals for client-side SDKs. ([#585](#585)) ([fd38a8f](fd38a8f)) * Implement support for browser requests. ([#578](#578)) ([887548a](887548a)) * Refactor data source connection handling. ([53f5bb8](53f5bb8)) * Scaffold browser client. ([#579](#579)) ([0848ab7](0848ab7)) ### Bug Fixes * Ensure browser contract tests run during top-level build. ([#589](#589)) ([7dfb14d](7dfb14d)) * Ensure client logger is always wrapped in a safe logger. ([#599](#599)) ([980e4da](980e4da)) </details> --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.