fix: Ensure browser contract tests run during top-level build. (#589)

launchdarkly · Sep 23, 2024 · 7dfb14d · 7dfb14d
1 parent 7131e69
commit 7dfb14d
Show file tree

Hide file tree

Showing 3 changed files with 9 additions and 15 deletions.
diff --git a/packages/sdk/browser/contract-tests/entity/package.json b/packages/sdk/browser/contract-tests/entity/package.json
@@ -5,7 +5,8 @@
   "type": "module",
   "description": "Contract test service implementation for @launchdarkly/js-client-sdk",
   "scripts": {
-    "start": "vite --open=true",
+    "start": "tsc --noEmit && vite --open=true",
+    "build": "tsc --noEmit && vite build",
     "lint": "eslint ./src",
     "prettier": "prettier --write '**/*.@(js|ts|tsx|json|css)' --ignore-path ../../../../.prettierignore"
   },

diff --git a/packages/sdk/browser/contract-tests/entity/src/ClientEntity.ts b/packages/sdk/browser/contract-tests/entity/src/ClientEntity.ts
@@ -1,10 +1,4 @@
-import {
-  AutoEnvAttributes,
-  init,
-  LDClient,
-  LDLogger,
-  LDOptions,
-} from '@launchdarkly/js-client-sdk';
+import { init, LDClient, LDLogger, LDOptions } from '@launchdarkly/js-client-sdk';
 
 import { CommandParams, CommandType, ValueType } from './CommandParams';
 import { CreateInstanceParams, SDKConfigParams } from './ConfigParams';
@@ -72,6 +66,8 @@ function makeSdkConfig(options: SDKConfigParams, tag: string) {
     };
   }
 
+  cf.fetchGoals = false;
+
   return cf;
 }
 
@@ -205,11 +201,7 @@ export async function newSdkClientEntity(options: CreateInstanceParams) {
     options.configuration.clientSide?.initialUser ||
     options.configuration.clientSide?.initialContext ||
     makeDefaultInitialContext();
-  const client = init(
-    options.configuration.credential || 'unknown-env-id',
-    AutoEnvAttributes.Disabled, // TODO: Determine capability.
-    sdkConfig,
-  );
+  const client = init(options.configuration.credential || 'unknown-env-id', sdkConfig);
   let failed = false;
   try {
     await Promise.race([

diff --git a/packages/sdk/browser/src/BrowserClient.ts b/packages/sdk/browser/src/BrowserClient.ts
@@ -10,6 +10,7 @@ import {
   LDContext,
   Platform,
 } from '@launchdarkly/js-client-sdk-common';
+import { LDIdentifyOptions } from '@launchdarkly/js-client-sdk-common/dist/api/LDIdentifyOptions';
 
 import GoalManager from './goals/GoalManager';
 import { Goal, isClick } from './goals/Goals';
@@ -135,8 +136,8 @@ export class BrowserClient extends LDClientImpl {
     };
   }
 
-  override async identify(context: LDContext): Promise<void> {
-    await super.identify(context);
+  override async identify(context: LDContext, identifyOptions?: LDIdentifyOptions): Promise<void> {
+    await super.identify(context, identifyOptions);
     this.goalManager?.startTracking();
   }
 }