Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[do not land][teaching] Proof of concept diff to show how streaming events get mapped from oboe helper for us to process #910

Closed
wants to merge 2 commits into from
Closed

[do not land][teaching] Proof of concept diff to show how streaming events get mapped from oboe helper for us to process #910

wants to merge 2 commits into from

Commits on Jan 13, 2024

  1. [2n] Disable Run Button: Create runningPromptId field to determine if… 

    … button should be disabled

I did a few things:

1. Create a new state id `runningPromptId` to check which prompt is running, making sure to set these correctly on run prompt actions
2. Read from this state in the AIConfigEditor and passed it as a prop down to the `RunPromptButton`

Question: Is there a better way of doing step #2 so that we don't need to keep piping it?

## Test Plan
Make sure that:
1. When you are running a prompt, you can still cancel it
2. When another prompt is running, you can't run any other prompt
3. When prompt is complete (or cancelled or errored), all the prompts can run again

https://github.com/lastmile-ai/aiconfig/assets/151060367/6e9a9cbf-6469-4ecb-ba74-1ede2ed1a292
    Rossdan Craig [email protected] committed Jan 13, 2024
    Configuration menu
    Copy the full SHA
    9a6575d View commit details
    Browse the repository at this point in the history

  2. [do not land][teaching] Proof of concept diff to show how streaming e… 

    …vents get mapped from oboe helper for us to process

This goes into a bit more detail on how streaming concepts are all connected together. I don't exactly know what `oboeInstance.node(on, fn);` does behind the scenes but you can just blackbox and know that it handles streaming for us
    Rossdan Craig [email protected] committed Jan 13, 2024
    Configuration menu
    Copy the full SHA
    1a24237 View commit details
    Browse the repository at this point in the history