[1/n] Basic repo setup #2
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TSIA -- just getting things set up
This was referenced Oct 5, 2023
This was referenced Oct 13, 2023
Merged
Merged
rossdanlm
pushed a commit
that referenced
this pull request
Jan 12, 2024
… button should be disabled I did a few things: 1. Create a new state id `runningPromptId` to check which prompt is running, making sure to set these correctly on run prompt actions 2. Read from this state in the AIConfigEditor and passed it as a prop down to the `RunPromptButton` Question: Is there a better way of doing step #2 so that we don't need to keep piping it? ## Test Plan Make sure that: 1. When you are running a prompt, you can still cancel it 2. When another prompt is running, you can't run any other prompt 3. When prompt is complete (or cancelled or errored), all the prompts can run again
rossdanlm
pushed a commit
that referenced
this pull request
Jan 12, 2024
… button should be disabled I did a few things: 1. Create a new state id `runningPromptId` to check which prompt is running, making sure to set these correctly on run prompt actions 2. Read from this state in the AIConfigEditor and passed it as a prop down to the `RunPromptButton` Question: Is there a better way of doing step #2 so that we don't need to keep piping it? ## Test Plan Make sure that: 1. When you are running a prompt, you can still cancel it 2. When another prompt is running, you can't run any other prompt 3. When prompt is complete (or cancelled or errored), all the prompts can run again https://github.com/lastmile-ai/aiconfig/assets/151060367/6e9a9cbf-6469-4ecb-ba74-1ede2ed1a292
rossdanlm
pushed a commit
that referenced
this pull request
Jan 12, 2024
… button should be disabled I did a few things: 1. Create a new state id `runningPromptId` to check which prompt is running, making sure to set these correctly on run prompt actions 2. Read from this state in the AIConfigEditor and passed it as a prop down to the `RunPromptButton` Question: Is there a better way of doing step #2 so that we don't need to keep piping it? ## Test Plan Make sure that: 1. When you are running a prompt, you can still cancel it 2. When another prompt is running, you can't run any other prompt 3. When prompt is complete (or cancelled or errored), all the prompts can run again https://github.com/lastmile-ai/aiconfig/assets/151060367/6e9a9cbf-6469-4ecb-ba74-1ede2ed1a292
rossdanlm
pushed a commit
that referenced
this pull request
Jan 13, 2024
… button should be disabled I did a few things: 1. Create a new state id `runningPromptId` to check which prompt is running, making sure to set these correctly on run prompt actions 2. Read from this state in the AIConfigEditor and passed it as a prop down to the `RunPromptButton` Question: Is there a better way of doing step #2 so that we don't need to keep piping it? ## Test Plan Make sure that: 1. When you are running a prompt, you can still cancel it 2. When another prompt is running, you can't run any other prompt 3. When prompt is complete (or cancelled or errored), all the prompts can run again https://github.com/lastmile-ai/aiconfig/assets/151060367/6e9a9cbf-6469-4ecb-ba74-1ede2ed1a292
rossdanlm
pushed a commit
that referenced
this pull request
Jan 13, 2024
… button should be disabled I did a few things: 1. Create a new state id `runningPromptId` to check which prompt is running, making sure to set these correctly on run prompt actions 2. Read from this state in the AIConfigEditor and passed it as a prop down to the `RunPromptButton` Question: Is there a better way of doing step #2 so that we don't need to keep piping it? ## Test Plan Make sure that: 1. When you are running a prompt, you can still cancel it 2. When another prompt is running, you can't run any other prompt 3. When prompt is complete (or cancelled or errored), all the prompts can run again https://github.com/lastmile-ai/aiconfig/assets/151060367/6e9a9cbf-6469-4ecb-ba74-1ede2ed1a292
rossdanlm
added a commit
that referenced
this pull request
Jan 13, 2024
…f button should be disabled (#907) [2n] Disable Run Button: Create runningPromptId field to determine if button should be disabled I did a few things: 1. Create a new state id `runningPromptId` to check which prompt is running, making sure to set these correctly on run prompt actions 2. Read from this state in the AIConfigEditor and passed it as a prop down to the `RunPromptButton` Question: Is there a better way of doing step #2 so that we don't need to keep piping it? ## Test Plan Make sure that: 1. When you are running a prompt, you can still cancel it 2. When another prompt is running, you can't run any other prompt 3. When prompt is complete (or cancelled or errored), all the prompts can run again https://github.com/lastmile-ai/aiconfig/assets/151060367/6e9a9cbf-6469-4ecb-ba74-1ede2ed1a292 --- Stack created with [Sapling](https://sapling-scm.com). Best reviewed with [ReviewStack](https://reviewstack.dev/lastmile-ai/aiconfig/pull/907). * __->__ #907 * #905
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[1/n] Basic repo setup
TSIA -- just getting things set up
Stack created with Sapling. Best reviewed with ReviewStack.