Revert "Build dmlc-core with old thread_local implementation (apache#…

…16526)" This reverts commit 1fb6f00.
larroy · Oct 25, 2019 · 94e72dd · 94e72dd
1 parent 67bb479
commit 94e72dd
Show file tree

Hide file tree

Showing 4 changed files with 1 addition and 86 deletions.
diff --git a/3rdparty/dmlc-core b/3rdparty/dmlc-core
diff --git a/CMakeLists.txt b/CMakeLists.txt
@@ -101,9 +101,6 @@ if("$ENV{VERBOSE}" STREQUAL "1")
   set(CMAKE_VERBOSE_MAKEFILE ON)
 endif()
 
-#Switch off modern thread local for dmlc-core, please see: https://github.com/dmlc/dmlc-core/issues/571#issuecomment-543467484
-add_definitions(-DDMLC_MODERN_THREAD_LOCAL=0)
-
 
 if(MSVC)
   add_definitions(-DWIN32_LEAN_AND_MEAN)

diff --git a/Makefile b/Makefile
@@ -94,8 +94,6 @@ include $(DMLC_CORE)/make/dmlc.mk
 # all tge possible warning tread
 WARNFLAGS= -Wall -Wsign-compare
 CFLAGS = -DMSHADOW_FORCE_STREAM $(WARNFLAGS)
-# use old thread local implementation in DMLC-CORE
-CFLAGS += -DDMLC_MODERN_THREAD_LOCAL=0
 
 ifeq ($(DEV), 1)
 	CFLAGS += -g -Werror

diff --git a/tests/cpp/engine/thread_local_test.cc b/tests/cpp/engine/thread_local_test.cc