Skip to content
This repository has been archived by the owner on Nov 17, 2023. It is now read-only.

Build dmlc-core with old thread_local implementation for MXNet #16526

Merged
merged 1 commit into from
Oct 21, 2019

Conversation

anirudh2290
Copy link
Member

Description

MXNet depends on thread local store from dmlc-core. There are two versions of Thread Local store implementations. One where the thread local object gets destructed when the spawned thread finishes and the other where thread local object is alive for the lifetime of the program. MXNet C API code is based on this assumption that the thread local object extends beyond the lifetime of the thread in which the API is called (assuming that it is called from a different thread). Example : https://github.com/apache/incubator-mxnet/blob/master/src/c_api/c_api_ndarray.cc#L251

Thus using the old implementation.
Required PR : dmlc/dmlc-core#573

Checklist

Essentials

Please feel free to remove inapplicable items for your PR.

  • The PR title starts with [MXNET-$JIRA_ID], where $JIRA_ID refers to the relevant JIRA issue created (except PRs with tiny changes)
  • Changes are complete (i.e. I finished coding on this PR)
  • All changes have test coverage:
  • Unit tests are added for small changes to verify correctness (e.g. adding a new operator)
  • Nightly tests are added for complicated/long-running ones (e.g. changing distributed kvstore)
  • Build tests will be added for build configuration changes (e.g. adding a new build option with NCCL)
  • Code is well-documented:
  • For user-facing API changes, API doc string has been updated.
  • For new C++ functions in header files, their functionalities and arguments are documented.
  • For new examples, README.md is added to explain the what the example does, the source of the dataset, expected performance on test set and reference to the original paper if applicable
  • Check the API doc at https://mxnet-ci-doc.s3-accelerate.dualstack.amazonaws.com/PR-$PR_ID/$BUILD_ID/index.html
  • To the my best knowledge, examples are either not affected by this change, or have been fixed to be compatible with this change

Changes

  • Feature1, tests, (and when applicable, API doc)
  • Feature2, tests, (and when applicable, API doc)

Comments

  • If this change is a backward incompatible change, why must this change be made.
  • Interesting edge cases to note here

@anirudh2290
Copy link
Member Author

@anirudh2290
Copy link
Member Author

anirudh2290 commented Oct 21, 2019

Thanks @szha ! Merging in an hour, unless someone has objections.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants