This repository has been archived by the owner on Nov 17, 2023. It is now read-only.
Build dmlc-core with old thread_local implementation for MXNet #16526
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
MXNet depends on thread local store from dmlc-core. There are two versions of Thread Local store implementations. One where the thread local object gets destructed when the spawned thread finishes and the other where thread local object is alive for the lifetime of the program. MXNet C API code is based on this assumption that the thread local object extends beyond the lifetime of the thread in which the API is called (assuming that it is called from a different thread). Example : https://github.com/apache/incubator-mxnet/blob/master/src/c_api/c_api_ndarray.cc#L251
Thus using the old implementation.
Required PR : dmlc/dmlc-core#573
Checklist
Essentials
Please feel free to remove inapplicable items for your PR.
Changes
Comments