Skip to content

Conversation

barryvdh
Copy link
Contributor

@barryvdh barryvdh commented Sep 24, 2025

As described in #57036 (comment)

The Request overview currently show:

  • The time (which is currently not taking into account the timezone) and which feels a bit unneeded when showing the current error.
  • Status: always 500, could be just shown in the url bar (added there) Edit: used the actual HTTP status
  • Method: is already shown in the error bar.

If the time is required, I would add it back in a different place and fix the timezone. Or just show the hour:minutes:seconds

I do agree that, especially on just your macbook screen, the stack trace is too low.

Example full-screen on Chrome with Macbook M2 Pro 14"

image I'm definitely not a designer, but the information seems a bit redundant, especially in the Overview section. Date: that is the current date so not sure why it's really relevant? Or add it shorter to the badges above the URl bar (just the time?)

Method: Already in the URL bar HTTP code: Maybe just add it before the method in the URL bar, or in the badges above it?

image

@shaedrich
Copy link
Contributor

shaedrich commented Sep 24, 2025

Hmmm … not sure if I like this 🤔

Before After Comment
image image
  • Why having a human readable error when the non-human readable error is highlighted?
  • The error class should be formatted as code to indicate that it is a class
image image
  • Why does the request method have to be red aside from a 405 HTTP response status code? It seems like "everything" is red now

– from #57036 (comment)

Would you mind considering making changes to these two?

@barryvdh
Copy link
Contributor Author

  • Why having a human readable error when the non-human readable error is highlighted?* The error class should be formatted as code to indicate that it is a class
image image * Why does the request method have to be red aside from a 405 HTTP response status code? It seems like "everything" is red now

– from #57036 (comment)

Would you mind considering making changes to these two?

Not really sure, maybe keep the PR as simple as possible. But my 2 cents:

  • I don't mind the class of the exception, it's for developers anyway
  • The HTTP status is always red, because the error page is hardcoded to HTTP error 500.

I could probably add the actual Error code though. Not sure about which colors are best though.

@taylorotwell taylorotwell merged commit 501efa1 into laravel:12.x Sep 24, 2025
62 of 63 checks passed
@barryvdh barryvdh deleted the tweak-exception-header branch September 24, 2025 18:24
tegos pushed a commit to tegos/laravel-framework that referenced this pull request Sep 28, 2025
* Remove Request overview from Exceptions

* Fix HTTP status code
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants