[12.x] Update local exception page #57036
Conversation
| public function onQueryExecuted(QueryExecuted $event) | ||
| { | ||
| if (count($this->queries) === 100) { | ||
| if (count($this->queries) === 101) { |
There was a problem hiding this comment.
Capture up to 101 queries to know whether there are more than 100 queries. We only display the first 100 queries on the UI.
|
What does this do? Here's no description or references in this pr. I'm wondering why a new dependency was added that can't be opted out: |
|
@glensc |
Maybe add screenshots (blog post?): just more information about what it is (and what it is not) |
|
@glensc here are the before and after for the same sample app. Before: 
After: 
I like the new design. I am just wondering if all text has enough contrast to meet accessibility requirements. |
|
Hmmm … not sure if I like this 🤔
|
|
@shaedrich the dark theme is auto-applied according to the user's browser's preferences. Which usually follows their system's settings. 
|
|
@rodrigopedra Ah, thanks for the explanation 👍🏻 which is convenient, but sometimes for different reasons, people want to have this different form their browser settings/system settings—why not have both? |
|
Although I like the new design, but I wish we could put a design competition and let the community pick the best one. |
|
Anyone on Windows with opcache issues with this new error page? Using php 8.3, the opcache crashes before reaching this page. The browser displays As for the page itself, really like the design. Only issue is that the Exception Trace is way too low. Need to scroll to see it. Too much white space. And the 3 rows of the overview could be placed elsewhere. Date could be beside the tags. Status code before the error. Method is already shown in the url part. |
|
I do agree that, especially on just your macbook screen, the stack trace is too low. Example full-screen on Chrome with Macbook M2 Pro 14" 
I'm definitely not a designer, but the information seems a bit redundant, especially in the Overview section. Method: Already in the URL bar 
|
Yes, I'm having the same issue, on PHP 8.4.2 on Windows 11. I've been trying to debug through process of elimination for a couple hours, first by removing packages from my project, then middleware, then tried a brand new install. Nothing worked.. Never thought to check and disable opache. Just tested and you're right. Disabling opcache worked, and now I no longer get the |
|
Created an issue #57171 . |
* Configure Vite with Tailwind CSS * Register new renderer template * Base layout with static content * Use dashed border * Add separator * Replace hard-coded values * Replace hard-coded query * Add empty state * Clean up section container * Clean up * Add section-container * Use section-container in topbar * Clean up * Extract query component * Add request-header component * Add request-body component * Add routing component * Add routing-parameter component * Add overview component * Add request-url component * Add header component * Add topbar component * Add trace component skeleton * Group exception frames * Add formatted-source and file-with-line components * Add frames * Add previous frame * Show code snippet without syntax highlight * Use exceptionAsMarkdown * Remove unused props * Assign snippet to a variable * Syntax highlight code snippet * Update phiki * Syntax highlight query, body, and route parameters * Update phiki * Use LineDecoration to highlight code snippet * Unescape highlighted text * Add syntax-highlight component * Handle files with less than 5 lines * Install Alpine.js * Add layout component * Add laravel-ascii component * Update method badge * Mark frame as main * Expand/collapse frames * Use current color in SVGs * Don't show callable when the frame doesn't have a class * Copy request URL to clipboard * Truncate long source * Add tooltip * wip: tooltip * Add side prop to tooltip * Add tooltip on request url * Prevent non-vendor frame from overflowing * Allow horizontal scroll on request body * Add tooltip on request headers * Add tooltip on database query * Hide JS-dependent elements until Alpine is loaded * Paginate queries * Add database icon * Add folder icons * Add copy icon * Add globe icon * Add alert icon * Copy exception as markdown * Add badge component * Add http-method component * Expand frames on clicking parent div * Open file in editor * Use pointer cursor on pagination buttons * Replace custom tooltip component with tippy.js * Upgrade phiki/phiki * Use dark-plus theme * Use dvh instead of screen * wip: light mode * Style gutter text * Only show the first 100 queries * light mode styling * Add light theme for syntax highlighter * Uppercase keys * Style copy as markdown button * Clean up * Add hover effect on laravel ascii logo * Add shadow * Fix tooltip position for queries * Tweak padding for mobile * Allow HTML in tooltip * Show frame arguments * Syntax highlight frame source * Add markdown template * Replace renderer directory * Simplify CSS rendering * Remove unused method * Revert unintended changes * Rename array key * Rename type to operator * Set max width for tooltip * Display vendor frames in two lines * Apply fixes from StyleCI * Add empty state for routing context * Only round top corners when frame is expanded * Update dot color for non-vendor frame * Update topbar height * Adjust padding around header section * Move up request url and have it overlap the separator line * Adjust spacing * Adjust spacing for mobile * Replace shadow-sm with shadow-xs * Apply bg-white without opacity in light mode * Adjust spacing --------- Co-authored-by: StyleCI Bot <[email protected]>
11 participants
No description provided.