Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow the --bench option to be used when publishing package config. #13

Closed
wants to merge 1 commit into from
Closed

Allow the --bench option to be used when publishing package config. #13

wants to merge 1 commit into from

Conversation

jasonlewis
Copy link
Contributor

Pretty much exactly what it says. You could use --bench when publishing assets but not config. Needed it so figured I'd send this in.

Signed-off-by: Jason Lewis [email protected]

@taylorotwell
Copy link
Member

I thought about this but couldn't see why it would be needed? Is there a use case for overriding your package configuration while you're actually developing it?

@jasonlewis
Copy link
Contributor Author

Now that you mention that it doesn't make a whole lot of sense really.

Blonde moment.

Cheers Taylor!

@jasonlewis jasonlewis closed this Jan 12, 2013
taylorotwell pushed a commit that referenced this pull request Jan 17, 2019
joelharkes pushed a commit to joelharkes/framework_old that referenced this pull request Mar 7, 2019
dbpolito pushed a commit to dbpolito/framework that referenced this pull request Oct 1, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants