-
Notifications
You must be signed in to change notification settings - Fork 11k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update to Laravel 8.70 breaks postAutoloadDump #39548
Comments
I have the same issue with Laravel v8.70.0 |
Please share your routes file |
Our development server went down after the update hmm. |
I can't help anyone until you share more information - thanks. |
@taylorotwell |
Nobody has shared a route file yet. |
@taylorotwell Seems routes like the following breaks: Route::get('foo', FooController::class)->name('foo'); |
Can confirm, this also breaks: |
Same here @taylorotwell. In a new project (Laravel Jetstream/Livewire), the only route I was working on is:
It worked until few minutes ago (on 8.69.0) |
Just saw this on the error above Target class [1\App\Http\Controllers\Api\GameApiController] Notice the |
@brunogaspar that route works for me in v8.70.0, please post the full routes file. |
hmm been reading merges in latest version, seems maybe withoutMiddleware is breaking it. |
|
Sorry, wrong button... @cage81 beat me to the route file. |
Do you actually have a valid action? Does your controller contain an __invoke method? |
It also happens on laravel/nova routes |
I wonder, how different is RouteServiceProvider for each of us and, does that contributes to that issue. |
Nope...same here, it's a Livewire full page component. |
@brunogaspar are you using Livewire as well? |
It also happens to livewire full page components which has __invoke from Livewire\Component |
@driesvints Not using Livewire and my controller do have I'm trying to understand what caused it to break, based on the changes. |
I use Laravel actions... |
seems issue is in src/Illuminate/Routing/RouteRegistrar.php |
return $this->attribute($method, $parameters[0] ?? null); Also works for me. |
@driesvints After reverting these change everything works again. EDIT: Reverting only the change in |
Thanks all. We're gonna get that fixed. Hold on for now. |
Please try these changes and report back if it fixes your problem: 5fda5a3 |
Works for me after those 2 changes. |
It works for me too with these changes. |
Yes works |
fixed, one but broke other hmm. at vendor/laravel/framework/src/Illuminate/Routing/RouteAction.php:92
9 routes/api.php:48
13 routes/api.php:152 Route - API: |
@Faks will need a smaller reproducible example than that. |
Released 8.70.1. |
@taylorotwell did update now everything returned to a stable working state. |
Test added to cover this case. |
Thank you! 👍 |
Description:
The artisan package discovery command throws an
UnexpectedValueException
when runningpostAutoloadDump
Invalid route action: [1\App\Actions\Calendar\CalendarEvents]
.I noticed a
1
in front of the class name.When I specifically set the Laravel framework to
v8.69.0
incomposer.json
and run it again, all works as it should.Steps To Reproduce:
sail composer update
Output
The text was updated successfully, but these errors were encountered: