-
Notifications
You must be signed in to change notification settings - Fork 11k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Request] Ability to rename the public folder #29
Comments
I've been meaning to mention this a few times. There is currently no way to change the public directory even though you can change |
+100 I've also mentioned this a few times. We just need a |
Not sure if I should be the one to have a go at implementing this. I can add the param to the start.php file but can't think of a clean way of getting that same value for the server.php file. I don't think we want to create another paths.php file like in laravel 3. Any thoughts on how to implement as cleanly as possible? |
Hmm you're right there. I think the only way to do it is have a third file which |
+1000 |
First I thought, this is a must, not all hostings have a "public" folder, so I've checked to see where things start to break (and figure out a patch for it). I haven't gone deeper with tests but, do I miss something? |
Grep the whole Laravel folder for 'public' I'm pretty sure it's there a few times, asset publishing for example. Also, many third party packages (eg basset) rely on the public folder Sent from my iPhone On 06/02/2013, at 7:16 AM, Jaume [email protected] wrote:
|
You're right @bencorlett grep -r "/public" . ./server.php:$requested = __DIR__.'/public'.$uri;
./server.php:require_once(__DIR__ . '/public/index.php');
./vendor/laravel/framework/src/Illuminate/Foundation/AssetPublisher.php: $source = $packagePath."/{$package}/public";
./vendor/laravel/framework/src/Illuminate/Foundation/Console/AssetPublishCommand.php: return $this->laravel['path.base']."/workbench/{$bench}/public";
./vendor/laravel/framework/src/Illuminate/Foundation/Providers/PublisherServiceProvider.php: $publicPath = $app['path.base'].'/public';
./vendor/laravel/framework/src/Illuminate/Workbench/PackageCreator.php: $this->files->makeDirectory($directory.'/public');
./vendor/laravel/framework/src/Illuminate/Workbench/PackageCreator.php: $this->files->put($directory.'/public/.gitkeep', ''); |
I guess I'm just waiting on Taylor to make a decision on this? How should we do it? |
The "$app['path.public']" options sounds good. The problem I see is with already published content. Maybe an Artisan command would be great, it would handle the rename/republish of the public folders from all the packages? |
+1 |
+1 for this, been needing it a lot of times. |
I may just put in a pull request in the morning for this. I have an idea of a nice implementation. Sent from my iPhone On 06/02/2013, at 10:25 PM, Maxime Fabre [email protected] wrote:
|
Sweet! =) |
What about it ? Is it possible to change folder name public to someting else ? |
Yes you can @danielczestki, e.g: crynobone/crynobone.com@c55ed05 |
good idea |
Would be great to be able to rename the public directory. For example in my hosting environment I use 'content' rather than 'public'. I'm sure lots of setups use other names such as httpdocs, public_html, etc
Or am I missing something and this already exists?
The text was updated successfully, but these errors were encountered: