Skip to content

Let Firefox users disable console #355

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
taylorotwell merged 4 commits into from
Sep 6, 2017
Merged

Let Firefox users disable console #355

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
5edb528
Let Firefox users disable console
deleugpn Sep 6, 2017
876b2eb
Loose the checking
deleugpn Sep 6, 2017
5eb2ade
Add Console tests
deleugpn Sep 6, 2017
0f6e88e
Loosen up check even more
deleugpn Sep 6, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 9 additions & 7 deletions src/Browser.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -229,13 +229,15 @@ public function screenshot($name)
*/
public function storeConsoleLog($name)
{
$console = $this->driver->manage()->getLog('browser');

if (! empty($console)) {
file_put_contents(
sprintf('%s/%s.log', rtrim(static::$storeConsoleLogAt, '/'), $name)
, json_encode($console, JSON_PRETTY_PRINT)
);
if (static::$storeConsoleLogAt) {
$console = $this->driver->manage()->getLog('browser');

if (!empty($console)) {
file_put_contents(
sprintf('%s/%s.log', rtrim(static::$storeConsoleLogAt, '/'), $name)
, json_encode($console, JSON_PRETTY_PRINT)
);
}
}

return $this;
Expand Down
20 changes: 20 additions & 0 deletions tests/BrowserTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -118,6 +118,26 @@ public function test_page_macros()

$this->assertTrue($browser->page->macroed);
}

public function test_retrieve_console()
{
$driver = Mockery::mock(StdClass::class);
$driver->shouldReceive('manage->getLog')->with('browser')->andReturnNull();
$browser = new Browser($driver);
Browser::$storeConsoleLogAt = 'not-null';

$browser->storeConsoleLog('file');
}

public function test_disable_console()
{
$driver = Mockery::mock(StdClass::class);
$driver->shouldNotReceive('manage');
$browser = new Browser($driver);
Browser::$storeConsoleLogAt = null;

$browser->storeConsoleLog('file');
}
}


Expand Down