Skip to content

Let Firefox users disable console#355

Merged
taylorotwell merged 4 commits intolaravel:2.0from
deleugpn:2.0
Sep 6, 2017
Merged

Let Firefox users disable console#355
taylorotwell merged 4 commits intolaravel:2.0from
deleugpn:2.0

Conversation

@deleugpn
Copy link
Contributor

@deleugpn deleugpn commented Sep 6, 2017

An alternative to #354.

When using Firefox, simply override the setUp method.

    protected function setUp()
    {
        parent::setUp();

        // Any of the following will be a valid option. The user can choose one
        Browser::$storeConsoleLogAt = null;
        Browser::$storeConsoleLogAt = false;
        Browser::$storeConsoleLogAt = '';
        unset(Browser::$storeConsoleLogAt);
    }
  • Why Firefox users should disable this themselves?

Dusk relies on Selenium to communicate with the browser and Selenium does offer getLog API (https://github.com/SeleniumHQ/selenium/wiki/JsonWireProtocol#log-type). Firefox hasn't caught up with that yet so if you do use Selenium with Firefox and make this API call, Firefox driver will fail and bubble up to Selenium. It doesn't necessarily mean that only Chrome offers this. PhantomJS is an example of that.

@taylorotwell taylorotwell merged commit 345d5a6 into laravel:2.0 Sep 6, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants