-
Notifications
You must be signed in to change notification settings - Fork 211
Fix belongsTo() method to be compatible with Laravel 4.1. #133
Conversation
+1 |
This fix works great for me. This should already be pulled, now that 4.1 is the current version. |
+1, Please merge this! |
+1 |
1 similar comment
+1 |
MERGEEEE!!!!! |
+1 |
For those not familiar with how to use a fork you can add this to your composer.json file until it's merged:
|
I would vote for this pull request as I had to do the exact same thing...so +1 |
+1 |
I think ardent's composer.json also needs to be updated to indicate that this change isn't compatible with Laravel 4.0. |
Merging, sorry for the lateness. Quite busy life :(( PS: @bexarcreative-daniel, you could have amended your first commit (: Even if you had pushed it already, you can amend and push-force it - no one would be hurt if no one was already using it ;) |
Fix belongsTo() method to be compatible with Laravel 4.1.
@bexarcreative-daniel would you - or anyone else in this issue - mind writing some update in the README explaining the changes? Looks like |
2.3.0 released, finally. Thanks for all the fish and I'm freaking sorry for taking so long with that :/ One more question: should the composer file be updated to require Laravel 4.1 now? |
@igorsantos07 I'll take care of the documentation. And yes, we should make a 4.1 minimal requirement. If someone is still using 4.0 then they will have to be locked at whatever version supports that. |
Done, thanks for the tip (2.3.1 released with the updated composer) and
|
@igorsantos07 documentation for this and some other new features are in #144. |
Using "bexarcreative-daniel" method, the validation problems are solved |
@amibct I'm not sure what the problem is that you're having. Could you clarify? I used my fork as provided above on a regular basis in projects. |
@bexarcreative-daniel |
This fixes the same issues that #123 pull request fixes but more extensively for models eager loaded
with()
relationships.