Skip to content
This repository has been archived by the owner on Jul 16, 2023. It is now read-only.

Update belongsTo and before/after callback calls to be compatible with Laravel 4.1 #123

Closed
wants to merge 2 commits into from

Conversation

brianwebb01
Copy link

This was a former pull request from Indatus:master now in its own branch Indatus:four-one-fixes

@thomaswelton
Copy link

@igorsantos07 @laravelbook have you done testing against laravel 4.1?
I'm hoping you can either merge this PR or implement your own fix as 4.1 should be getting released over the next few weeks. And I'd like to start testing the new features on my dev site soon.
Thanks

@brianwebb01
Copy link
Author

Yes, this was created because of trying to use ardent with 4.1, however I did notice that there are issues with the ardent relationship declarations in 4.1. Looks like the relationships maybe aren't getting instantiated.

@igorsantos07
Copy link
Member

@thomaswelton I'm not using Ardent actively anymore and I still couldn't find enough free time to give some love to the project... That's why we don't have tests yet.

And, just to make it clear, I haven't tested Ardent against 4.1.

Anyway, I'll accept the PR and release it as pre-release, like I did before. Thanks!

@igorsantos07
Copy link
Member

@brianwebb01 the method was renamed to belongsTobelongsTo... Please fix it before I merge (:

@ejunker
Copy link

ejunker commented Dec 9, 2013

+1 I'm testing my app against 4.1 and ran into the issue with BelongsTo, would love to see the fix merged in so that I can start using 4.1

@mvalim
Copy link

mvalim commented Dec 11, 2013

any news on that?

@dschu-lab
Copy link

Yeah. Would you please merge the fix?

@webpatser
Copy link

yeah.. since it's official now ;-)

@igorsantos07
Copy link
Member

Closing since @bexarcreative-daniel did a better job and fixed what this PR couldn't, as it was poorly written and also forgotten by the owner.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.