Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Transition from DeviceArray to jax.Array #410

Merged
merged 18 commits into from
Apr 21, 2023
Merged

Transition from DeviceArray to jax.Array #410

merged 18 commits into from
Apr 21, 2023

Conversation

bwohlberg
Copy link
Collaborator

Transition from DeviceArray to jax.Array, the new JAX array type from 0.4.1 onwards.

@bwohlberg bwohlberg added documentation Improvements or additions to documentation typing Related to type annotations labels Apr 21, 2023
@bwohlberg bwohlberg added the packaging Issues related to packaging, dependencies, etc. label Apr 21, 2023
@codecov
Copy link

codecov bot commented Apr 21, 2023

Codecov Report

Merging #410 (902efe7) into main (418865f) will increase coverage by 0.28%.
The diff coverage is 99.50%.

@@            Coverage Diff             @@
##             main     #410      +/-   ##
==========================================
+ Coverage   94.43%   94.71%   +0.28%     
==========================================
  Files          83       83              
  Lines        5103     5093      -10     
==========================================
+ Hits         4819     4824       +5     
+ Misses        284      269      -15     
Flag Coverage Δ
unittests 94.71% <99.50%> (+0.28%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
scico/typing.py 100.00% <ø> (ø)
scico/linop/_convolve.py 86.31% <83.33%> (ø)
scico/__init__.py 100.00% <100.00%> (ø)
scico/data/__init__.py 100.00% <100.00%> (ø)
scico/denoiser.py 88.67% <100.00%> (-0.11%) ⬇️
scico/examples.py 96.00% <100.00%> (ø)
scico/flax/_flax.py 100.00% <100.00%> (ø)
scico/flax/blocks.py 100.00% <100.00%> (ø)
scico/flax/examples/data_generation.py 74.82% <100.00%> (-0.72%) ⬇️
scico/flax/examples/data_preprocessing.py 94.96% <100.00%> (+0.03%) ⬆️
... and 49 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Copy link
Contributor

@Michael-T-McCann Michael-T-McCann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pending results of off-github discussion on snp.Array vs scico.typing.Array

@bwohlberg bwohlberg merged commit 090e607 into main Apr 21, 2023
@bwohlberg bwohlberg deleted the brendt/jaxarray branch April 21, 2023 20:37
@bwohlberg
Copy link
Collaborator Author

See also #181.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation packaging Issues related to packaging, dependencies, etc. typing Related to type annotations
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Replace DeviceArray with Array in the docs JAX array typing confusion
2 participants