Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace DeviceArray with Array in the docs #373

Closed
Michael-T-McCann opened this issue Dec 22, 2022 · 1 comment · Fixed by #410
Closed

Replace DeviceArray with Array in the docs #373

Michael-T-McCann opened this issue Dec 22, 2022 · 1 comment · Fixed by #410
Labels
documentation Improvements or additions to documentation

Comments

@Michael-T-McCann
Copy link
Contributor

JAX has introduced jax.Array, which "subsumes DeviceArray, ShardedDeviceArray, and GlobalDeviceArray" (see https://jax.readthedocs.io/en/latest/jax_array_migration.html). So, if we want to talk about the JAX array type, it should be Array, not DeviceArray as we were previously doing in many places in the docs.
@Michael-T-McCann Michael-T-McCann added documentation Improvements or additions to documentation typing Related to type annotations labels Dec 22, 2022
@Michael-T-McCann Michael-T-McCann changed the title Replace DeviceArray with Array in the docs Replace DeviceArray with Array in the docs and type annotations Dec 22, 2022
@Michael-T-McCann Michael-T-McCann changed the title Replace DeviceArray with Array in the docs and type annotations Replace DeviceArray with Array in the docs Dec 22, 2022
@Michael-T-McCann Michael-T-McCann removed the typing Related to type annotations label Dec 22, 2022
@Michael-T-McCann Michael-T-McCann mentioned this issue Dec 22, 2022
Merged
@bwohlberg
Copy link
Collaborator

See also #327.

@bwohlberg bwohlberg linked a pull request Apr 21, 2023 that will close this issue
Transition from DeviceArray to jax.Array #410
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
documentation Improvements or additions to documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Transition from DeviceArray to jax.Array lanl/scico
2 participants
@bwohlberg @Michael-T-McCann