Skip to content

2020.07.15 Meeting Notes

Jump to bottom
Philipp Grete edited this page Jul 15, 2020 · 2 revisions

Agenda

Participants: Galen, Josh B., Carola, Daniel, Forrest, Geoffrey, Jim, Philipp, Sriram

  • Individual/group updates

    • AthenaPK
      • PG: added automated performance regression test. Couple of other small PR (dev model, updating streams/threads)
      • FG: worked on buffer packing and optimizing the kernel (runtime down to 20us). Will continue to try "Jim's" solution. Galen offers to setup call with NVidia folks.
      • JS: Provided test code for optimized uniform grid buffer filling (using a single buffer)
    • LANL CS
      • JB: added code coverage and working on internal Power9 CI (Cuda works, OpenMP works, but not together using gcc -- got fixed during the call, was a cmake issue. PG creates bug report.). Raises point on lack of performance measure support in Catch2 (e.g., bandwidth).
      • SS: reviewed streams/threads PR
      • CE: getting up to speed with Parthenon
      • GS: Introduces Carola (will work on Parthenon performance), Daniel (working on Kokkos optimization), Geoffrey (member of the Kokkos team, will support performance)
    • LANL Physics
      • SS reports: JD was working on updating LANL physics code to work with latest Parthenon.

  • Location of "gold standard" files for testing

    • Key question: where to store (potentially large amounts of) binary data used in regression tests
    • GS: for a different (internal) project: storing gold standard directly in the repo (order few GB) works but not that conve nient
    • General agreement: no binary data in the version controlled repo
    • Make sure there's a cmake target to download the data

  • Updated development model

    • PG mentioned that PR 3226 is open for discussion
    • GS: It may potentially advantages to have a fixed major version in addition to a YY.MM tag

  • How to set number of host threads? Environment variable or input file parameter.

    • PG+JS: Env. variables are not necessarily obvious (-> motivation to be specific about it in the input file)
    • JS: input parameters are also stored in the restart files
    • SS: Can we override from the command line? Yes, all input parameters can be overridden -> using input parameter works.
    • PG: Will add warning if environment variable and input parameter don't align.

  • Quick run-through of outstanding non-WIP pull request reviews

    • #226 waiting for general comments
    • #224 waiting for review by LANL physics
    • #216 continue discussion based on results from this call
    • #210 SS is double checking requested changed
    • #204 AG has been pinged for final review of doc
    • #193 Made WIP again due to bug
    • #190 PG updates by end of the week following reviews
    • #187 Ping LANL physics team for final comments
Clone this wiki locally