Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: increase the default concurrency of Celery worker #6354

Closed

Conversation

bowenliang123
Copy link
Contributor

Checklist:

Important

Please review the checklist below before submitting your pull request.

  • Please open an issue before creating a PR or link to an existing issue
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I ran dev/reformat(backend) and cd web && npx lint-staged(frontend) to appease the lint gods

Description

  • before this PR, the async tasks often get blocked when only one worker instance started, as the default concurrency controlled by entrypoint.sh is set to 1
  • considering the suggested default concurrency of celery worker command is the number of CPUs available on your system, it's reasonable to increasing to 3

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update, included: Dify Document
  • Improvement, including but not limited to code refactoring, performance optimization, and UI/UX improvement
  • Dependency upgrade

Testing Instructions

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • Test A
  • Test B

@dosubot dosubot bot added the size:XS This PR changes 0-9 lines, ignoring generated files. label Jul 17, 2024
@bowenliang123
Copy link
Contributor Author

cc @JohnJyong

@bowenliang123 bowenliang123 changed the title fix: increase the default celery worker concurrency fix: increase the default concurrency of Celery worker Jul 17, 2024
@crazywoola
Copy link
Member

See this one #6249

@bowenliang123
Copy link
Contributor Author

See this one #6249

Cool~

@bowenliang123 bowenliang123 deleted the worker-concurrency branch July 17, 2024 01:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size:XS This PR changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants