Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: support Celery auto-scale #6249

Merged
merged 13 commits into from
Jul 31, 2024
Merged

feat: support Celery auto-scale #6249

merged 13 commits into from
Jul 31, 2024

Conversation

ZuzooVn
Copy link
Contributor

@ZuzooVn ZuzooVn commented Jul 12, 2024

Checklist:

Important

Please review the checklist below before submitting your pull request.

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I ran dev/reformat(backend) and cd web && npx lint-staged(frontend) to appease the lint gods

Description

Support Celery auto-scale

Fixes

Type of Change

  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update, included: Dify Document

@dosubot dosubot bot added the size:M This PR changes 30-99 lines, ignoring generated files. label Jul 12, 2024
@crazywoola crazywoola requested a review from takatost July 12, 2024 12:10
@crazywoola crazywoola mentioned this pull request Jul 17, 2024
Closed
12 tasks
@ZuzooVn ZuzooVn requested a review from bowenliang123 July 24, 2024 07:19
takatost
takatost requested changes Jul 24, 2024
View reviewed changes
api/docker/entrypoint.sh Outdated Show resolved Hide resolved
@ZuzooVn
set to 1 workers even if CELERY_WORKER_AMOUNT is not set
cff1279 
otherwise users will automatically start multiple workers after upgrading to the next version, resulting in insufficient memory resources and OOM
@ZuzooVn ZuzooVn requested a review from takatost July 30, 2024 23:34
takatost
takatost approved these changes Jul 31, 2024
View reviewed changes
Copy link
Collaborator

@takatost takatost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks

@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Jul 31, 2024
@takatost takatost merged commit 8eb0d0f into langgenius:main Jul 31, 2024
5 checks passed
@ZuzooVn ZuzooVn deleted the celery-worker-auto-scale branch August 5, 2024 09:16
@takatost takatost mentioned this pull request Aug 5, 2024
Merged
cuiks pushed a commit to cuiks/dify that referenced this pull request Aug 6, 2024
@ZuzooVn @takatost @cuiks
feat: support Celery auto-scale (langgenius#6249)
e97516f 
Co-authored-by: takatost <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@takatost takatost takatost approved these changes

@bowenliang123 bowenliang123 Awaiting requested review from bowenliang123

Assignees
No one assigned
Labels
lgtm This PR has been approved by a maintainer size:M This PR changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ZuzooVn @bowenliang123 @takatost