Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: ContentBlockDisplay styling for block titles #4550

Merged
merged 3 commits into from
Nov 12, 2024

Conversation

anovazzi1
Copy link
Contributor

This PR fixes the issue with the ContentBlockDisplay component not displaying block titles correctly. The commit removes the reverse bug logic in the playground and updates the conditional rendering logic for the block title in ContentBlockDisplay. It also adjusts the styling to ensure proper alignment and spacing. Ref: #4533.

@dosubot dosubot bot added size:XS This PR changes 0-9 lines, ignoring generated files. bug Something isn't working labels Nov 12, 2024
@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Nov 12, 2024
The ContentBlockDisplay component was not displaying block titles correctly. This commit fixes the issue by updating the conditional rendering logic for the block title and adjusting the styling to ensure proper alignment and spacing.

Ref: #4533
@github-actions github-actions bot added bug Something isn't working and removed bug Something isn't working labels Nov 12, 2024
@ogabrielluiz ogabrielluiz merged commit e2bdaf5 into main Nov 12, 2024
19 checks passed
@ogabrielluiz ogabrielluiz deleted the fixSpacingPlaygroun branch November 12, 2024 23:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working lgtm This PR has been approved by a maintainer size:XS This PR changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants