fix: added new image to get started templates, fixed sidebar overlapping bug #4533
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dosubot
bot
added
the
size:M
…t in small screens
dosubot
bot
added
size:L
anovazzi1
added a commit
that referenced
this pull request
Nov 12, 2024
The ContentBlockDisplay component was not displaying block titles correctly. This commit fixes the issue by updating the conditional rendering logic for the block title and adjusting the styling to ensure proper alignment and spacing. Ref: #4533
ogabrielluiz
pushed a commit
that referenced
this pull request
Nov 12, 2024
The ContentBlockDisplay component was not displaying block titles correctly. This commit fixes the issue by updating the conditional rendering logic for the block title and adjusting the styling to ensure proper alignment and spacing. Ref: #4533
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request includes several changes to the frontend components and styles, focusing on updating image assets, modifying styles, and refactoring code for better readability and maintainability.
Image and Style Updates:
src/frontend/src/modals/templatesModal/components/GetStartedComponent/index.tsx: Replaced spiral images with new temporary pattern images and added horizontal variants for responsive design. [1] [2]src/frontend/src/modals/templatesModal/components/TemplateGetStartedCardComponent/index.tsx: Updated the component to use new image assets and adjusted the layout to handle both standard and horizontal images. [1] [2]Code Refactoring:
src/frontend/src/types/templates/types.ts: Modified theCardDatainterface to replacebgandspiralImageproperties withbgImageandbgHorizontalImagefor consistency with updated image assets.Minor Style Adjustments:
src/frontend/src/components/ui/sidebar.tsx: Adjusted the z-index and class order for better layering and transition effects.src/frontend/src/modals/baseModal/helpers/switch-case-size.ts: Slightly reduced the maximum height for the "templates" modal size to improve layout consistency.