Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: update flaky tests in test_schema.py #3933

Merged
merged 5 commits into from
Sep 27, 2024
Merged

Conversation

ogabrielluiz
Copy link
Contributor

This pull request fixes the import order in test_database.py and resolves flaky tests in test_schema.py by using sets for more reliable type comparisons. The changes ensure better code organization and improve the stability of the tests.

- Updated `post_process_type` function assertions to use sets for more reliable type comparisons.
- Adjusted imports for better code organization.
@dosubot dosubot bot added size:S This PR changes 10-29 lines, ignoring generated files. python Pull requests that update Python code labels Sep 26, 2024
@github-actions github-actions bot added the refactor Maintenance tasks and housekeeping label Sep 26, 2024
Copy link

This pull request is automatically being deployed by Amplify Hosting (learn more).

Access this pull request here: https://pr-3933.dmtpw4p5recq1.amplifyapp.com

@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Sep 26, 2024
@ogabrielluiz ogabrielluiz enabled auto-merge (squash) September 27, 2024 12:06
@ogabrielluiz ogabrielluiz merged commit 706f9a0 into main Sep 27, 2024
28 checks passed
@ogabrielluiz ogabrielluiz deleted the fix/flaky-tests branch September 27, 2024 16:45
diogocabral pushed a commit to headlinevc/langflow that referenced this pull request Nov 26, 2024
* Fix flaky tests in `test_schema.py` by using sets for type comparisons

- Updated `post_process_type` function assertions to use sets for more reliable type comparisons.
- Adjusted imports for better code organization.

* Fix import order in test_database.py

* [autofix.ci] apply automated fixes

---------

Co-authored-by: autofix-ci[bot] <114827586+autofix-ci[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lgtm This PR has been approved by a maintainer python Pull requests that update Python code refactor Maintenance tasks and housekeeping size:S This PR changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants