Skip to content

Commit

Permalink
refactor: update flaky tests in test_schema.py (langflow-ai#3933)
Browse files Browse the repository at this point in the history
* Fix flaky tests in `test_schema.py` by using sets for type comparisons

- Updated `post_process_type` function assertions to use sets for more reliable type comparisons.
- Adjusted imports for better code organization.

* Fix import order in test_database.py

* [autofix.ci] apply automated fixes

---------

Co-authored-by: autofix-ci[bot] <114827586+autofix-ci[bot]@users.noreply.github.com>
  • Loading branch information
2 people authored and diogocabral committed Nov 26, 2024
1 parent 6455d54 commit bd66ac0
Show file tree
Hide file tree
Showing 2 changed files with 8 additions and 8 deletions.
2 changes: 1 addition & 1 deletion src/backend/tests/unit/test_database.py
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,6 @@
from collections import namedtuple
from uuid import UUID, uuid4

from langflow.services.database.models.folder.model import FolderCreate
import orjson
import pytest
from fastapi.testclient import TestClient
Expand All @@ -13,6 +12,7 @@
from langflow.initial_setup.setup import load_flows_from_directory, load_starter_projects
from langflow.services.database.models.base import orjson_dumps
from langflow.services.database.models.flow import Flow, FlowCreate, FlowUpdate
from langflow.services.database.models.folder.model import FolderCreate
from langflow.services.database.utils import session_getter
from langflow.services.deps import get_db_service

Expand Down
14 changes: 7 additions & 7 deletions src/backend/tests/unit/test_schema.py
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
from typing import Union
from collections.abc import Sequence
from typing import Union

import pytest
from pydantic import ValidationError
Expand Down Expand Up @@ -40,11 +40,11 @@ def test_validate_type_class(self):
assert input_obj.field_type == "int"

def test_post_process_type_function(self):
assert post_process_type(int) == [int]
assert post_process_type(list[int]) == [int]
assert post_process_type(Union[int, str]) == [int, str]
assert post_process_type(Union[int, Sequence[str]]) == [int, str]
assert post_process_type(Union[int, Sequence[int]]) == [int]
assert set(post_process_type(int)) == {int}
assert set(post_process_type(list[int])) == {int}
assert set(post_process_type(Union[int, str])) == {int, str}
assert set(post_process_type(Union[int, Sequence[str]])) == {int, str}
assert set(post_process_type(Union[int, Sequence[int]])) == {int}

def test_input_to_dict(self):
input_obj = Input(field_type="str")
Expand Down Expand Up @@ -110,7 +110,7 @@ def test_list_int_type(self):
assert post_process_type(list[int]) == [int]

def test_union_type(self):
assert post_process_type(Union[int, str]) == [int, str]
assert set(post_process_type(Union[int, str])) == {int, str}

def test_custom_type(self):
class CustomType:
Expand Down

0 comments on commit bd66ac0

Please sign in to comment.