Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Fix Text Splitters #3783

Merged
merged 2 commits into from
Sep 17, 2024
Merged

Conversation

cbornet
Copy link
Collaborator

@cbornet cbornet commented Sep 12, 2024

It seems the change in #3757 creates some kind of conflicts and the Data output of text splitters cannot be linked anymore.
This PR fixes this and also makes the code simpler.

@dosubot dosubot bot added size:XS This PR changes 0-9 lines, ignoring generated files. bug Something isn't working labels Sep 12, 2024
@github-actions github-actions bot added bug Something isn't working and removed bug Something isn't working labels Sep 12, 2024
Copy link

This pull request is automatically being deployed by Amplify Hosting (learn more).

Access this pull request here: https://pr-3783.dmtpw4p5recq1.amplifyapp.com

Copy link
Collaborator

@jordanrfrazier jordanrfrazier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested this does fix the issue, but have no idea why didn't work previously

@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Sep 17, 2024
@jordanrfrazier jordanrfrazier enabled auto-merge (squash) September 17, 2024 23:34
@jordanrfrazier jordanrfrazier merged commit f17de26 into langflow-ai:main Sep 17, 2024
36 of 37 checks passed
@cbornet cbornet deleted the fix-text-splitters branch September 23, 2024 14:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working lgtm This PR has been approved by a maintainer size:XS This PR changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants