Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add CassandraGraphVectorStoreComponent and HtmlLinkExtractorComponent #3757

Merged
merged 6 commits into from
Sep 11, 2024

Conversation

cbornet
Copy link
Collaborator

@cbornet cbornet commented Sep 10, 2024

This adds:

@dosubot dosubot bot added size:L This PR changes 100-499 lines, ignoring generated files. enhancement New feature or request labels Sep 10, 2024
@github-actions github-actions bot added enhancement New feature or request and removed enhancement New feature or request labels Sep 10, 2024
Copy link

This pull request is automatically being deployed by Amplify Hosting (learn more).

Access this pull request here: https://pr-3757.dmtpw4p5recq1.amplifyapp.com

@github-actions github-actions bot added enhancement New feature or request and removed enhancement New feature or request labels Sep 10, 2024
"Could not import cassio integration package. " "Please install it with `pip install cassio`."
)

from uuid import UUID
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe could be a global import, if only just for the sanity check that uuid is available at component load time?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

uuid is built-in so it will always be available.
I don't mind making it a global import. This part of code was copy/pasted from CassandraVectorStoreComponent.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

# use a copy because we can't change the type of the parameter
database_ref = self.database_ref.split(",")

if is_astra:
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not to add an unnecessary complication but does it make sense to have a specific AstraDBGraphVectorStore in the way we have a separate AstraDBVectorStore?

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the CassandraGraphVectorStore is CQL based, and AstraDBVectorStore is dataAPI based.

We are independently working on a AstraDBGraphVectorStore that is dataAPI based.

Copy link
Collaborator

@erichare erichare left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fantastic, two minor comments

from langflow.custom import Component
from langflow.io import Output
from langflow.schema import Data
from langflow.utils.util import build_loader_repr_from_data


class LCTextSplitterComponent(Component):
class LCTextSplitterComponent(LCDocumentTransformerComponent):
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are there any risks to this change for other flows that use the LCTextSplitterComponent?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't know. I don't see what could go wrong but...

@cbornet cbornet force-pushed the graph_vs branch 2 times, most recently from fe5ff67 to b0002a8 Compare September 11, 2024 10:58
@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Sep 11, 2024
@italojohnny italojohnny merged commit 7273a6e into langflow-ai:main Sep 11, 2024
30 checks passed
anovazzi1 added a commit that referenced this pull request Sep 11, 2024
This commit adds the CalculatorToolComponent to the langflow/components/tools directory. The CalculatorToolComponent allows users to perform basic arithmetic operations on a given expression. It includes an input for the expression and returns the result or an error message.

Ref: #3757
@cbornet cbornet deleted the graph_vs branch September 11, 2024 21:01
Cristhianzl pushed a commit that referenced this pull request Sep 11, 2024
* feat: Add CalculatorToolComponent to langflow/components/tools

This commit adds the CalculatorToolComponent to the langflow/components/tools directory. The CalculatorToolComponent allows users to perform basic arithmetic operations on a given expression. It includes an input for the expression and returns the result or an error message.

Ref: #3757

* lint

* [autofix.ci] apply automated fixes

---------

Co-authored-by: autofix-ci[bot] <114827586+autofix-ci[bot]@users.noreply.github.com>
@cbornet cbornet mentioned this pull request Sep 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request lgtm This PR has been approved by a maintainer size:L This PR changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants