test(astra): Refactor AstraDB imports in test_astra_component #3413
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dosubot
bot
added
the
size:S
Pull Request Validation ReportThis comment is automatically generated by Conventional PR Whitelist Report
Result Pull request does not satisfy any enabled whitelist criteria. Pull request will be validated. Validation Report
Result Pull request satisfies all enabled pull request rules. Last Modified at 18 Aug 24 14:18 UTC |
github-actions
bot
added
test
|
This pull request is automatically being deployed by Amplify Hosting (learn more). |
| @@ -186,6 +190,8 @@ def test_astra_vectorize_with_provider_api_key(): | |||
| ) | |||
| def test_astra_vectorize_passes_authentication(): | |||
| """tests vectorize using the authentication parameter""" | |||
| from langchain_astradb import AstraDBVectorStore, CollectionVectorServiceOptions | |||
There was a problem hiding this comment.
ruff got it - need to add from langflow.components.embeddings.AstraVectorize import AstraVectorizeComponent
ogabrielluiz
force-pushed
the
chore-refactor-integration-tests-imports
branch
from
01562c5 to
43d9ada
Compare
jordanrfrazier
approved these changes
Aug 20, 2024
ogabrielluiz
added a commit
that referenced
this pull request
Aug 20, 2024
* test(astra): Refactor AstraDB imports in test_astra_component * fix: Add AstraVectorizeComponent to AstraDB tests.
ogabrielluiz
added a commit
that referenced
this pull request
Aug 20, 2024
* test(astra): Refactor AstraDB imports in test_astra_component * fix: Add AstraVectorizeComponent to AstraDB tests.
ogabrielluiz
added a commit
that referenced
this pull request
Aug 21, 2024
* test(astra): Refactor AstraDB imports in test_astra_component * fix: Add AstraVectorizeComponent to AstraDB tests.
ogabrielluiz
added a commit
that referenced
this pull request
Aug 21, 2024
* test(astra): Refactor AstraDB imports in test_astra_component * fix: Add AstraVectorizeComponent to AstraDB tests.
ogabrielluiz
added a commit
that referenced
this pull request
Aug 21, 2024
* feat: Refactor how configuration attributes are handled in Component class. * refactor: Update method name to handle singular and plural inputs. * refactor: Add value validation for input and attribute assignment. * test: Add test for setting invalid input in task component. * fix: add param without underscore to inputs * test(astra): Refactor AstraDB imports in test_astra_component (#3413) * test(astra): Refactor AstraDB imports in test_astra_component * fix: Add AstraVectorizeComponent to AstraDB tests. * fix: Refactor custom component error message for setting parameter or attribute. * test(astra): Refactor AstraDB imports in test_astra_component (#3413) * test(astra): Refactor AstraDB imports in test_astra_component * fix: Add AstraVectorizeComponent to AstraDB tests. * chore: Refactor joining methods list in _set_parameter_or_attribute function. * refactor: Refactor error message string formatting in Component class.
anovazzi1
pushed a commit
that referenced
this pull request
Aug 21, 2024
* feat: Refactor how configuration attributes are handled in Component class. * refactor: Update method name to handle singular and plural inputs. * refactor: Add value validation for input and attribute assignment. * test: Add test for setting invalid input in task component. * fix: add param without underscore to inputs * test(astra): Refactor AstraDB imports in test_astra_component (#3413) * test(astra): Refactor AstraDB imports in test_astra_component * fix: Add AstraVectorizeComponent to AstraDB tests. * fix: Refactor custom component error message for setting parameter or attribute. * test(astra): Refactor AstraDB imports in test_astra_component (#3413) * test(astra): Refactor AstraDB imports in test_astra_component * fix: Add AstraVectorizeComponent to AstraDB tests. * chore: Refactor joining methods list in _set_parameter_or_attribute function. * refactor: Refactor error message string formatting in Component class.
anovazzi1
pushed a commit
that referenced
this pull request
Aug 26, 2024
* test(astra): Refactor AstraDB imports in test_astra_component * fix: Add AstraVectorizeComponent to AstraDB tests.
anovazzi1
pushed a commit
that referenced
this pull request
Aug 26, 2024
* feat: Refactor how configuration attributes are handled in Component class. * refactor: Update method name to handle singular and plural inputs. * refactor: Add value validation for input and attribute assignment. * test: Add test for setting invalid input in task component. * fix: add param without underscore to inputs * test(astra): Refactor AstraDB imports in test_astra_component (#3413) * test(astra): Refactor AstraDB imports in test_astra_component * fix: Add AstraVectorizeComponent to AstraDB tests. * fix: Refactor custom component error message for setting parameter or attribute. * test(astra): Refactor AstraDB imports in test_astra_component (#3413) * test(astra): Refactor AstraDB imports in test_astra_component * fix: Add AstraVectorizeComponent to AstraDB tests. * chore: Refactor joining methods list in _set_parameter_or_attribute function. * refactor: Refactor error message string formatting in Component class.
ogabrielluiz
added a commit
that referenced
this pull request
Aug 27, 2024
* test(astra): Refactor AstraDB imports in test_astra_component * fix: Add AstraVectorizeComponent to AstraDB tests.
ogabrielluiz
added a commit
that referenced
this pull request
Aug 27, 2024
* feat: Refactor how configuration attributes are handled in Component class. * refactor: Update method name to handle singular and plural inputs. * refactor: Add value validation for input and attribute assignment. * test: Add test for setting invalid input in task component. * fix: add param without underscore to inputs * test(astra): Refactor AstraDB imports in test_astra_component (#3413) * test(astra): Refactor AstraDB imports in test_astra_component * fix: Add AstraVectorizeComponent to AstraDB tests. * fix: Refactor custom component error message for setting parameter or attribute. * test(astra): Refactor AstraDB imports in test_astra_component (#3413) * test(astra): Refactor AstraDB imports in test_astra_component * fix: Add AstraVectorizeComponent to AstraDB tests. * chore: Refactor joining methods list in _set_parameter_or_attribute function. * refactor: Refactor error message string formatting in Component class.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just some refactor to minimize error messages