Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: improve attribute compatibility and error messages #3367

Merged
merged 10 commits into from
Aug 21, 2024
Merged

refactor: improve attribute compatibility and error messages #3367

merged 10 commits into from
Aug 21, 2024

Conversation

ogabrielluiz
Copy link
Contributor

@ogabrielluiz ogabrielluiz commented Aug 15, 2024 •
edited
Loading

Improves errors and kwargs handling in Component

@dosubot dosubot bot added the size:S This PR changes 10-29 lines, ignoring generated files. label Aug 15, 2024
@github-actions GitHub Actions
Copy link
Contributor

Pull Request Validation Report

This comment is automatically generated by Conventional PR

Whitelist Report

Whitelist Active Result
Pull request is a draft and should be ignored ✅ ❌
Pull request is made by a whitelisted user and should be ignored ❌ ❌
Pull request is submitted by a bot and should be ignored ✅ ❌
Pull request is submitted by administrators and should be ignored ❌ ❌

Result

Pull request does not satisfy any enabled whitelist criteria. Pull request will be validated.

Validation Report

Validation Active Result
All commits in this pull request has valid messages ❌ ✅
Pull request does not introduce too many changes ❌ ✅
Pull request has mentioned issues ❌ ✅
Pull request has valid branch name ❌ ✅
Pull request should have a non-empty body ✅ ❌
Pull request has a valid title ✅ ❌

Result

Pull request is invalid.

Reason

  • Pull request must have a non-empty body
  • Pull request title does not follow the desired pattern

Last Modified at 15 Aug 24 19:14 UTC

@aws-amplify-sa-east-1 AWS Amplify (sa-east-1)
Copy link

This pull request is automatically being deployed by Amplify Hosting (learn more).

Access this pull request here: https://pr-3367.dmtpw4p5recq1.amplifyapp.com

@dosubot dosubot bot added size:M This PR changes 30-99 lines, ignoring generated files. and removed size:S This PR changes 10-29 lines, ignoring generated files. labels Aug 15, 2024
@ogabrielluiz ogabrielluiz changed the title Virtual branch 1 refactor: improve attribute compatibility and error messages Aug 15, 2024
@github-actions github-actions bot added the refactor Maintenance tasks and housekeeping label Aug 15, 2024
@italojohnny italojohnny self-requested a review August 16, 2024 13:53
@ogabrielluiz ogabrielluiz force-pushed the refactor-improve-attribute-compatibility-and-error-messages branch 2 times, most recently from fefe4d4 to 443dca7 Compare August 16, 2024 19:32
@github-actions github-actions bot added refactor Maintenance tasks and housekeeping and removed refactor Maintenance tasks and housekeeping labels Aug 16, 2024
@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Aug 19, 2024
@ogabrielluiz
test(astra): Refactor AstraDB imports in test_astra_component (#3413)
d5f1ad1 
* test(astra): Refactor AstraDB imports in test_astra_component

* fix: Add AstraVectorizeComponent to AstraDB tests.
@ogabrielluiz ogabrielluiz force-pushed the refactor-improve-attribute-compatibility-and-error-messages branch from 443dca7 to ea7fe5c Compare August 20, 2024 19:54
@ogabrielluiz
fix: Refactor custom component error message for setting parameter or…
63d6bce 
… attribute.
@ogabrielluiz
test(astra): Refactor AstraDB imports in test_astra_component (#3413)
5e2bb81 
* test(astra): Refactor AstraDB imports in test_astra_component

* fix: Add AstraVectorizeComponent to AstraDB tests.
@ogabrielluiz ogabrielluiz force-pushed the refactor-improve-attribute-compatibility-and-error-messages branch 2 times, most recently from e1dafdb to e9c1e3c Compare August 20, 2024 20:00
@ogabrielluiz ogabrielluiz force-pushed the refactor-improve-attribute-compatibility-and-error-messages branch 2 times, most recently from 2a7e639 to 47b19f6 Compare August 21, 2024 11:43
@ogabrielluiz ogabrielluiz force-pushed the refactor-improve-attribute-compatibility-and-error-messages branch from 47b19f6 to f71689a Compare August 21, 2024 12:26
@ogabrielluiz ogabrielluiz enabled auto-merge (squash) August 21, 2024 12:34
@ogabrielluiz ogabrielluiz merged commit bf650ec into main Aug 21, 2024
29 checks passed
@ogabrielluiz ogabrielluiz deleted the refactor-improve-attribute-compatibility-and-error-messages branch August 21, 2024 12:34
anovazzi1 pushed a commit that referenced this pull request Aug 21, 2024
@ogabrielluiz @anovazzi1
refactor: improve attribute compatibility and error messages (#3367)
c7125d8 
* feat: Refactor how configuration attributes are handled in Component class.

* refactor: Update method name to handle singular and plural inputs.

* refactor: Add value validation for input and attribute assignment.

* test: Add test for setting invalid input in task component.

* fix: add param without underscore to inputs

* test(astra): Refactor AstraDB imports in test_astra_component (#3413)

* test(astra): Refactor AstraDB imports in test_astra_component

* fix: Add AstraVectorizeComponent to AstraDB tests.

* fix: Refactor custom component error message for setting parameter or attribute.

* test(astra): Refactor AstraDB imports in test_astra_component (#3413)

* test(astra): Refactor AstraDB imports in test_astra_component

* fix: Add AstraVectorizeComponent to AstraDB tests.

* chore: Refactor joining methods list in _set_parameter_or_attribute function.

* refactor: Refactor error message string formatting in Component class.
anovazzi1 pushed a commit that referenced this pull request Aug 26, 2024
@ogabrielluiz @anovazzi1
refactor: improve attribute compatibility and error messages (#3367)
4f641f7 
* feat: Refactor how configuration attributes are handled in Component class.

* refactor: Update method name to handle singular and plural inputs.

* refactor: Add value validation for input and attribute assignment.

* test: Add test for setting invalid input in task component.

* fix: add param without underscore to inputs

* test(astra): Refactor AstraDB imports in test_astra_component (#3413)

* test(astra): Refactor AstraDB imports in test_astra_component

* fix: Add AstraVectorizeComponent to AstraDB tests.

* fix: Refactor custom component error message for setting parameter or attribute.

* test(astra): Refactor AstraDB imports in test_astra_component (#3413)

* test(astra): Refactor AstraDB imports in test_astra_component

* fix: Add AstraVectorizeComponent to AstraDB tests.

* chore: Refactor joining methods list in _set_parameter_or_attribute function.

* refactor: Refactor error message string formatting in Component class.
ogabrielluiz added a commit that referenced this pull request Aug 27, 2024
@ogabrielluiz
refactor: improve attribute compatibility and error messages (#3367)
1ef7e27 
* feat: Refactor how configuration attributes are handled in Component class.

* refactor: Update method name to handle singular and plural inputs.

* refactor: Add value validation for input and attribute assignment.

* test: Add test for setting invalid input in task component.

* fix: add param without underscore to inputs

* test(astra): Refactor AstraDB imports in test_astra_component (#3413)

* test(astra): Refactor AstraDB imports in test_astra_component

* fix: Add AstraVectorizeComponent to AstraDB tests.

* fix: Refactor custom component error message for setting parameter or attribute.

* test(astra): Refactor AstraDB imports in test_astra_component (#3413)

* test(astra): Refactor AstraDB imports in test_astra_component

* fix: Add AstraVectorizeComponent to AstraDB tests.

* chore: Refactor joining methods list in _set_parameter_or_attribute function.

* refactor: Refactor error message string formatting in Component class.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@italojohnny italojohnny italojohnny approved these changes

Assignees
No one assigned
Labels
lgtm This PR has been approved by a maintainer refactor Maintenance tasks and housekeeping size:M This PR changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ogabrielluiz @italojohnny