Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: fix test after changes on LLMs components #2538

Merged
merged 5 commits into from
Jul 4, 2024
Merged

Conversation

Cristhianzl
Copy link
Member

test: remove redundant test assertions in filterEdge-shard-0.spec.ts
test: add new test assertions and remove redundant ones in filterEdge-shard-1.spec.ts

…c.ts

✅ (tests): add new test assertions and remove redundant ones in filterEdge-shard-1.spec.ts
@Cristhianzl Cristhianzl requested a review from ogabrielluiz July 4, 2024 18:06
@Cristhianzl Cristhianzl self-assigned this Jul 4, 2024
@dosubot dosubot bot added size:S This PR changes 10-29 lines, ignoring generated files. javascript Pull requests that update Javascript code labels Jul 4, 2024
Copy link
Contributor

github-actions bot commented Jul 4, 2024

Pull Request Validation Report

This comment is automatically generated by Conventional PR

Whitelist Report

Whitelist Active Result
Pull request is a draft and should be ignored
Pull request is made by a whitelisted user and should be ignored
Pull request is submitted by a bot and should be ignored
Pull request is submitted by administrators and should be ignored

Result

Pull request does not satisfy any enabled whitelist criteria. Pull request will be validated.

Validation Report

Validation Active Result
All commits in this pull request has valid messages
Pull request does not introduce too many changes
Pull request has a valid title
Pull request has mentioned issues
Pull request has valid branch name
Pull request should have a non-empty body

Result

Pull request satisfies all enabled pull request rules.

Last Modified at 04 Jul 24 18:07 UTC

@ogabrielluiz ogabrielluiz enabled auto-merge (squash) July 4, 2024 18:13
Cristhianzl and others added 3 commits July 4, 2024 15:29
@ogabrielluiz ogabrielluiz disabled auto-merge July 4, 2024 18:43
@ogabrielluiz ogabrielluiz enabled auto-merge (squash) July 4, 2024 18:43
@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Jul 4, 2024
@github-actions github-actions bot added the test Changes to tests label Jul 4, 2024
@ogabrielluiz ogabrielluiz merged commit 2b8d314 into main Jul 4, 2024
29 checks passed
@ogabrielluiz ogabrielluiz deleted the cz/fixTestCI branch July 4, 2024 18:54
ogabrielluiz added a commit to yaitec/langflow that referenced this pull request Jul 9, 2024
* ✅ (tests): remove redundant test assertions in filterEdge-shard-0.spec.ts
✅ (tests): add new test assertions and remove redundant ones in filterEdge-shard-1.spec.ts

* ✅ (filterSidebar.spec.ts): add test for visibility of helpersID Generator
♻️ (filterSidebar.spec.ts): remove redundant visibility test for textsplittersCharacterTextSplitter

---------

Co-authored-by: Gabriel Luiz Freitas Almeida <[email protected]>
nicoloboschi pushed a commit to datastax/ragstack-ai-langflow that referenced this pull request Jul 10, 2024
* ✅ (tests): remove redundant test assertions in filterEdge-shard-0.spec.ts
✅ (tests): add new test assertions and remove redundant ones in filterEdge-shard-1.spec.ts

* ✅ (filterSidebar.spec.ts): add test for visibility of helpersID Generator
♻️ (filterSidebar.spec.ts): remove redundant visibility test for textsplittersCharacterTextSplitter

---------

Co-authored-by: Gabriel Luiz Freitas Almeida <[email protected]>
(cherry picked from commit 2b8d314)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
javascript Pull requests that update Javascript code lgtm This PR has been approved by a maintainer size:S This PR changes 10-29 lines, ignoring generated files. test Changes to tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants