-
Notifications
You must be signed in to change notification settings - Fork 4.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test: fix test after changes on LLMs components #2538
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…c.ts ✅ (tests): add new test assertions and remove redundant ones in filterEdge-shard-1.spec.ts
dosubot
bot
added
size:S
This PR changes 10-29 lines, ignoring generated files.
javascript
Pull requests that update Javascript code
labels
Jul 4, 2024
Pull Request Validation ReportThis comment is automatically generated by Conventional PR Whitelist Report
Result Pull request does not satisfy any enabled whitelist criteria. Pull request will be validated. Validation Report
Result Pull request satisfies all enabled pull request rules. Last Modified at 04 Jul 24 18:07 UTC |
…ator ♻️ (filterSidebar.spec.ts): remove redundant visibility test for textsplittersCharacterTextSplitter
ogabrielluiz
approved these changes
Jul 4, 2024
ogabrielluiz
added a commit
to yaitec/langflow
that referenced
this pull request
Jul 9, 2024
* ✅ (tests): remove redundant test assertions in filterEdge-shard-0.spec.ts ✅ (tests): add new test assertions and remove redundant ones in filterEdge-shard-1.spec.ts * ✅ (filterSidebar.spec.ts): add test for visibility of helpersID Generator ♻️ (filterSidebar.spec.ts): remove redundant visibility test for textsplittersCharacterTextSplitter --------- Co-authored-by: Gabriel Luiz Freitas Almeida <[email protected]>
nicoloboschi
pushed a commit
to datastax/ragstack-ai-langflow
that referenced
this pull request
Jul 10, 2024
* ✅ (tests): remove redundant test assertions in filterEdge-shard-0.spec.ts ✅ (tests): add new test assertions and remove redundant ones in filterEdge-shard-1.spec.ts * ✅ (filterSidebar.spec.ts): add test for visibility of helpersID Generator ♻️ (filterSidebar.spec.ts): remove redundant visibility test for textsplittersCharacterTextSplitter --------- Co-authored-by: Gabriel Luiz Freitas Almeida <[email protected]> (cherry picked from commit 2b8d314)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
javascript
Pull requests that update Javascript code
lgtm
This PR has been approved by a maintainer
size:S
This PR changes 10-29 lines, ignoring generated files.
test
Changes to tests
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
test: remove redundant test assertions in filterEdge-shard-0.spec.ts
test: add new test assertions and remove redundant ones in filterEdge-shard-1.spec.ts