Skip to content

Commit

Permalink
test: fix test after changes on LLMs components (#2538)
Browse files Browse the repository at this point in the history
* ✅ (tests): remove redundant test assertions in filterEdge-shard-0.spec.ts
✅ (tests): add new test assertions and remove redundant ones in filterEdge-shard-1.spec.ts

* ✅ (filterSidebar.spec.ts): add test for visibility of helpersID Generator
♻️ (filterSidebar.spec.ts): remove redundant visibility test for textsplittersCharacterTextSplitter

---------

Co-authored-by: Gabriel Luiz Freitas Almeida <[email protected]>
  • Loading branch information
Cristhianzl and ogabrielluiz authored Jul 4, 2024
1 parent a933139 commit 2b8d314
Show file tree
Hide file tree
Showing 3 changed files with 7 additions and 13 deletions.
6 changes: 0 additions & 6 deletions src/frontend/tests/end-to-end/filterEdge-shard-0.spec.ts
Original file line number Diff line number Diff line change
Expand Up @@ -55,9 +55,6 @@ test("LLMChain - Tooltip", async ({ page }) => {
await expect(
page.getByTestId("available-output-chains").first(),
).toBeVisible();
await expect(
page.getByTestId("available-output-textsplitters").first(),
).toBeVisible();
await expect(
page.getByTestId("available-output-retrievers").first(),
).toBeVisible();
Expand All @@ -73,9 +70,6 @@ test("LLMChain - Tooltip", async ({ page }) => {
await expect(
page.getByTestId("available-output-toolkits").first(),
).toBeVisible();
await expect(
page.getByTestId("available-output-chains").first(),
).toBeVisible();
await expect(
page.getByTestId("available-output-agents").first(),
).toBeVisible();
Expand Down
9 changes: 5 additions & 4 deletions src/frontend/tests/end-to-end/filterEdge-shard-1.spec.ts
Original file line number Diff line number Diff line change
Expand Up @@ -69,10 +69,13 @@ test("LLMChain - Filter", async ({ page }) => {
await expect(page.getByTestId("disclosure-memories")).toBeVisible();
await expect(page.getByTestId("disclosure-prototypes")).toBeVisible();
await expect(page.getByTestId("disclosure-retrievers")).toBeVisible();
await expect(page.getByTestId("disclosure-text splitters")).toBeVisible();
await expect(page.getByTestId("disclosure-toolkits")).toBeVisible();
await expect(page.getByTestId("disclosure-tools")).toBeVisible();

await expect(page.getByTestId("helpersID Generator").first()).toBeVisible();

await expect(page.getByTestId("agentsCSVAgent").first()).toBeVisible();

await expect(page.getByTestId("chainsLLMChain").first()).toBeVisible();
await expect(
page.getByTestId("langchain_utilitiesSearchApi").first(),
Expand All @@ -86,9 +89,7 @@ test("LLMChain - Filter", async ({ page }) => {
await expect(
page.getByTestId("retrieversAmazon Kendra Retriever").first(),
).toBeVisible();
await expect(
page.getByTestId("textsplittersCharacterTextSplitter").first(),
).toBeVisible();

await expect(
page.getByTestId("toolkitsVectorStoreInfo").first(),
).toBeVisible();
Expand Down
5 changes: 2 additions & 3 deletions src/frontend/tests/end-to-end/filterSidebar.spec.ts
Original file line number Diff line number Diff line change
Expand Up @@ -50,6 +50,7 @@ test("LLMChain - Filter", async ({ page }) => {
)
.click();

await expect(page.getByTestId("helpersID Generator")).toBeVisible();
await expect(page.getByTestId("disclosure-agents")).toBeVisible();

await expect(page.getByTestId("chainsLLMChain").first()).toBeVisible();
Expand All @@ -65,9 +66,7 @@ test("LLMChain - Filter", async ({ page }) => {
await expect(
page.getByTestId("retrieversAmazon Kendra Retriever").first(),
).toBeVisible();
await expect(
page.getByTestId("textsplittersCharacterTextSplitter").first(),
).toBeVisible();

await expect(
page.getByTestId("toolkitsVectorStoreInfo").first(),
).toBeVisible();
Expand Down

0 comments on commit 2b8d314

Please sign in to comment.