fix: change DirectoryComponent to filter file paths by types #2391
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dosubot
bot
added
the
size:XS
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
ogabrielluiz
requested changes
Jun 27, 2024
There was a problem hiding this comment.
The component is wrong I think. The types field should be a list field. That's why the self.types requires a call to split but shouldn't.
There was a problem hiding this comment.
@ogabrielluiz Please verify the corrections applied.
dosubot
bot
added
size:S
…nd adding a comment for type hint ignore in ChatGroq instantiation.
ogabrielluiz
changed the title
ogabrielluiz
changed the title
ogabrielluiz
approved these changes
Jul 4, 2024
github-actions
bot
added
bug
* Refactored mutation and query types and callables * Refactored version and other queries to new way of calling function * update type declaration to support options * update getVersionQuery * [autofix.ci] apply automated fixes * update type declaration to remove on Fetch options * remove onFetch from version * update transactions query * [autofix.ci] apply automated fixes --------- Co-authored-by: anovazzi1 <[email protected]> Co-authored-by: autofix-ci[bot] <114827586+autofix-ci[bot]@users.noreply.github.com> Co-authored-by: cristhianzl <[email protected]>
* opentelemetry and prometheus * set env override in create_app * add prometheus_client to pyproject * update top level poetry.lock
* update getHealth function to use options param * [autofix.ci] apply automated fixes --------- Co-authored-by: autofix-ci[bot] <114827586+autofix-ci[bot]@users.noreply.github.com>
* fix version * [autofix.ci] apply automated fixes --------- Co-authored-by: autofix-ci[bot] <114827586+autofix-ci[bot]@users.noreply.github.com>
chore: Add conditional step to delete-reports job in TypeScript test workflow
* fix: pasting files not working * [autofix.ci] apply automated fixes * refactor: change new import --------- Co-authored-by: autofix-ci[bot] <114827586+autofix-ci[bot]@users.noreply.github.com> Co-authored-by: cristhianzl <[email protected]> Co-authored-by: anovazzi1 <[email protected]>
dosubot
bot
added
size:L
ogabrielluiz
added a commit
to yaitec/langflow
that referenced
this pull request
Jul 9, 2024
…w-ai#2391) * Refactor DirectoryComponent to filter file paths by types * fix: sets types is_list to True * chore: Remove Optional from load_directory method signature * chore: Update return type annotation for load_directory method * style(GroqModel.py): improve code readability by fixing indentation and adding a comment for type hint ignore in ChatGroq instantiation. --------- Co-authored-by: Gabriel Luiz Freitas Almeida <[email protected]>
nicoloboschi
pushed a commit
to datastax/ragstack-ai-langflow
that referenced
this pull request
Jul 10, 2024
…w-ai#2391) * Refactor DirectoryComponent to filter file paths by types * fix: sets types is_list to True * chore: Remove Optional from load_directory method signature * chore: Update return type annotation for load_directory method * style(GroqModel.py): improve code readability by fixing indentation and adding a comment for type hint ignore in ChatGroq instantiation. --------- Co-authored-by: Gabriel Luiz Freitas Almeida <[email protected]> (cherry picked from commit bc6b846)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The "Type" option of the component has been adjusted to ensure the file type is selected correctly.