Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ordering): correctly remove vertex from list of runnable vertices #2554

Merged
merged 1 commit into from
Jul 5, 2024

Conversation

ogabrielluiz
Copy link
Contributor

Vertices in the first layer were being removed from runnable vertices at /build/{flow_id}/vertices call but they should actually be removed at the get_next_runnable_vertices call.

Also, in get_next_runnable_vertices they were being remove only from predecessors but should actually be removed from runnable vertices.

@dosubot dosubot bot added size:XS This PR changes 0-9 lines, ignoring generated files. bug Something isn't working labels Jul 5, 2024
Copy link
Contributor

github-actions bot commented Jul 5, 2024

Pull Request Validation Report

This comment is automatically generated by Conventional PR

Whitelist Report

Whitelist Active Result
Pull request is a draft and should be ignored
Pull request is made by a whitelisted user and should be ignored
Pull request is submitted by a bot and should be ignored
Pull request is submitted by administrators and should be ignored

Result

Pull request does not satisfy any enabled whitelist criteria. Pull request will be validated.

Validation Report

Validation Active Result
All commits in this pull request has valid messages
Pull request does not introduce too many changes
Pull request has a valid title
Pull request has mentioned issues
Pull request has valid branch name
Pull request should have a non-empty body

Result

Pull request satisfies all enabled pull request rules.

Last Modified at 05 Jul 24 13:21 UTC

@ogabrielluiz ogabrielluiz enabled auto-merge (squash) July 5, 2024 13:23
@github-actions github-actions bot added bug Something isn't working and removed bug Something isn't working labels Jul 5, 2024
@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Jul 5, 2024
@github-actions github-actions bot added bug Something isn't working and removed bug Something isn't working labels Jul 5, 2024
Copy link
Contributor

@anovazzi1 anovazzi1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ogabrielluiz ogabrielluiz merged commit 3900c58 into main Jul 5, 2024
31 checks passed
@ogabrielluiz ogabrielluiz deleted the fix/orderissue branch July 5, 2024 13:30
nicoloboschi pushed a commit to datastax/ragstack-ai-langflow that referenced this pull request Jul 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working lgtm This PR has been approved by a maintainer size:XS This PR changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants