[core/indexer] Reverts PR #25754 and add unit tests #28702
Merged
+64
−276
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Skipped Deployment
|
dosubot
bot
added
size:L
KeiichiHirobe
commented
Dec 13, 2024
| @@ -630,26 +630,18 @@ def test_incremental_delete( | |||
| } | |||
|
|
|||
|
|
|||
| def test_incremental_indexing_with_batch_size( | |||
| def test_incremental_delete_with_same_source( | |||
There was a problem hiding this comment.
Unfortunately, the diff in test_indexing.py is very confusing, but test_incremental_delete_with_same_source is the only test case I newly created. I recommend reviewing the diff for each commit.
| "num_deleted": 0, | ||
| "num_skipped": 4, | ||
| "num_deleted": 1, | ||
| "num_skipped": 1, |
There was a problem hiding this comment.
I confirmed that the original logic returned num_deleted = 0, which is an obviously unexpected result.
|
Related to PR: #25754 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I reported the bug 2 weeks ago here: #28447
I believe this is a critical bug for the indexer, so I submitted a PR to revert the change and added unit tests to prevent similar bugs from being introduced in the future.
@eyurtsev Could you check this?