Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug] [core/indexer] PR #25754 seems like introducing bugs #28447

Open
5 tasks done
KeiichiHirobe opened this issue Dec 2, 2024 · 2 comments
Open
5 tasks done

[Bug] [core/indexer] PR #25754 seems like introducing bugs #28447

KeiichiHirobe opened this issue Dec 2, 2024 · 2 comments
Labels
🤖:bug Related to a bug, vulnerability, unexpected error with an existing feature

Comments

@KeiichiHirobe
Copy link
Contributor

Checked other resources

  • I added a very descriptive title to this issue.
  • I searched the LangChain documentation with the integrated search.
  • I used the GitHub search to find a similar question and didn't find it.
  • I am sure that this is a bug in LangChain rather than my code.
  • The bug is not resolved by updating to the latest stable version of LangChain (or the specific integration package).

Example Code

None

Error Message and Stack Trace (if applicable)

None

Description

#25754 seems like introducing bugs.

Let's say we have 3 records a, b, c with the same source_id, and someone will delete the record c.
The indexer should delete a record for c from vector database and record manager, but it won't after the PR was merged because docs_to_index doesn't include the source_id.

System Info

None
@dosubot dosubot bot added the 🤖:bug Related to a bug, vulnerability, unexpected error with an existing feature label Dec 2, 2024
@KeiichiHirobe KeiichiHirobe mentioned this issue Dec 13, 2024
Merged
@eyurtsev
Copy link
Collaborator

Confirmed

@eyurtsev
Copy link
Collaborator

@KeiichiHirobe thank you for the simple example!

eyurtsev pushed a commit that referenced this issue Dec 13, 2024
@KeiichiHirobe
core[patch]: Reverts PR #25754 and add unit tests (#28702)
da28cf1 
I reported the bug 2 weeks ago here:
#28447

I believe this is a critical bug for the indexer, so I submitted a PR to
revert the change and added unit tests to prevent similar bugs from
being introduced in the future.

@eyurtsev Could you check this?
@duartecaldascardoso duartecaldascardoso mentioned this issue Dec 17, 2024
Closed
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
🤖:bug Related to a bug, vulnerability, unexpected error with an existing feature
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@eyurtsev @KeiichiHirobe