Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: 🐛 PDF Filter Type Error #27154

Merged
merged 4 commits into from
Dec 13, 2024
Merged

fix: 🐛 PDF Filter Type Error #27154

Changes from 2 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
d9c4323
fix: 🐛 PDF Filter Type Error
moyueheng Oct 6, 2024
0cb13bb
Merge branch 'master' into master
moyueheng Oct 11, 2024
416e9f8
Merge branch 'master' into master
efriis Dec 13, 2024
1db4def
x
efriis Dec 13, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 9 additions & 3 deletions libs/community/langchain_community/document_loaders/parsers/pdf.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -235,14 +235,20 @@ def get_image(layout_object: Any) -> Any:

images = []

for img in list(filter(bool, map(get_image, page))):
if img.stream["Filter"].name in _PDF_FILTER_WITHOUT_LOSS:
for img in filter(bool, map(get_image, page)):
img_filter = img.stream["Filter"]
if isinstance(img_filter, list):
filter_names = [f.name for f in img_filter]
else:
filter_names = [img_filter.name]

if any(name in _PDF_FILTER_WITHOUT_LOSS for name in filter_names):
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if both are passed, should we throw an error that only one or the other should be passed?

images.append(
np.frombuffer(img.stream.get_data(), dtype=np.uint8).reshape(
img.stream["Height"], img.stream["Width"], -1
)
)
elif img.stream["Filter"].name in _PDF_FILTER_WITH_LOSS:
elif any(name in _PDF_FILTER_WITH_LOSS for name in filter_names):
images.append(img.stream.get_data())
else:
warnings.warn("Unknown PDF Filter!")
Expand Down